From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758117AbbEaGY1 (ORCPT ); Sun, 31 May 2015 02:24:27 -0400 Received: from isilmar-3.linta.de ([188.40.101.200]:46796 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754455AbbEaGYT (ORCPT ); Sun, 31 May 2015 02:24:19 -0400 Date: Sun, 31 May 2015 08:07:20 +0200 From: Dominik Brodowski To: "Ryan C. Underwood" Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Disable write buffering on Toshiba ToPIC95 Message-ID: <20150531060720.GA9898@light.dominikbrodowski.net> References: <1422230829-14823-1-git-send-email-nemesis@icequake.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <1422230829-14823-1-git-send-email-nemesis@icequake.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ryan, thanks for this patch. Could you add a "Signed-off-by" line as specified in Documentation/SubmittingPatches, please, so that I can pick it up and push it upstream? Thanks! Dominik On Sun, Jan 25, 2015 at 04:07:09PM -0800, Ryan C. Underwood wrote: > From: Ryan Underwood >=20 > Disable write buffering on the Toshiba ToPIC95 if it is enabled by somebo= dy (it > is not supposed to be a power-on default according to the datasheet). On= the > ToPIC95, practically no 32-bit Cardbus card will work under heavy load wi= thout > locking up the whole system if this is left enabled. I tried about a doz= en. > It does not affect 16-bit cards. This is similar to the O2 bugs in early > controller revisions it seems. Originally posted to > https://bugzilla.kernel.org/show_bug.cgi?id=3D55961 > --- > drivers/pcmcia/topic.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/drivers/pcmcia/topic.h b/drivers/pcmcia/topic.h > index 615a45a..582688fe 100644 > --- a/drivers/pcmcia/topic.h > +++ b/drivers/pcmcia/topic.h > @@ -104,6 +104,9 @@ > #define TOPIC_EXCA_IF_CONTROL 0x3e /* 8 bit */ > #define TOPIC_EXCA_IFC_33V_ENA 0x01 > =20 > +#define TOPIC_PCI_CFG_PPBCN 0x3e /* 16-bit */ > +#define TOPIC_PCI_CFG_PPBCN_WBEN 0x0400 > + > static void topic97_zoom_video(struct pcmcia_socket *sock, int onoff) > { > struct yenta_socket *socket =3D container_of(sock, struct yenta_socket,= socket); > @@ -138,6 +141,7 @@ static int topic97_override(struct yenta_socket *sock= et) > static int topic95_override(struct yenta_socket *socket) > { > u8 fctrl; > + u16 ppbcn; > =20 > /* enable 3.3V support for 16bit cards */ > fctrl =3D exca_readb(socket, TOPIC_EXCA_IF_CONTROL); > @@ -146,6 +150,18 @@ static int topic95_override(struct yenta_socket *soc= ket) > /* tell yenta to use exca registers to power 16bit cards */ > socket->flags |=3D YENTA_16BIT_POWER_EXCA | YENTA_16BIT_POWER_DF; > =20 > + /* Disable write buffers to prevent lockups under load with numerous > + Cardbus cards, observed on Tecra 500CDT and reported elsewhere on the > + net. This is not a power-on default according to the datasheet > + but some BIOSes seem to set it. */ > + if (pci_read_config_word(socket->dev, TOPIC_PCI_CFG_PPBCN, &ppbcn) =3D= =3D 0 > + && socket->dev->revision <=3D 7 > + && (ppbcn & TOPIC_PCI_CFG_PPBCN_WBEN)) { > + ppbcn &=3D ~TOPIC_PCI_CFG_PPBCN_WBEN; > + pci_write_config_word(socket->dev, TOPIC_PCI_CFG_PPBCN, ppbcn); > + dev_info(&socket->dev->dev, "Disabled ToPIC95 Cardbus write buffers.\n= "); > + } > + > return 0; > } > =20 > --=20 > 1.9.1 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVaqUYAAoJEJqXYIlMjaMNbGQP/0TZcx5bUIdK1CB6kFpyLYrq 7lZZ8a9JZqUceyQY5M44GYhmEtzxHqPJUZhgD/d0GJzyxYc4UTNH9cm+YmTnxwyY 0HRXV1MlL3YIeEJab4+OsrppRjMHsxqYuFqZ2o+hSoHCbxfOK8+nMKfaeXgQC2mv yctHrks/f7TORAQYnfmBbnwIjCA9JI/RVpt7ieRBl1cHO+0MejuoqPC4SDjx1lwS S0RzHN4Ebu8g6GnEm3qvZm1pqER0xI/UsHHlHnVLkQV/OJuo6HFlq/qGX3+KwqCl uJe2ZUknxHTPfnDx/UCxyMkfLGGLlQ178zcpGlh9CxCA1VszgJKc83OGj0e4CFqn HCnWneZbWxnEuEDYaota8ef9c7MpTx9lzCt8UT/OvGX+XI6H2ASRrtaYPtBT5OCa d0iuTFS0hjfduqrwuVI+S3an85r4MeDTbHkQ9Kb1g6OVrubBBM7PDb4e8Mddau+r 9sRZ8n7KD1g+P0T/8yd5xnyI5gyPeRRrTvsaiUs1AhK0Slb2EcYYkvYZCwF7CMLG RchdFRJNORdb5Mu2cRiwn+VKOylEKU9bMVCi7Z/yQmFRKg0ISFK/oivvDOqkenmG bIIeKKl6sRWBDEwnX6ECaN0EjjTQStI64hUfW4MIjQob4pSHEjwr3VhTBumhsM+P UDj0UiqKP9RuAWIFuFz8 =lJO8 -----END PGP SIGNATURE----- --huq684BweRXVnRxX--