From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932264AbbEaGno (ORCPT ); Sun, 31 May 2015 02:43:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40985 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758180AbbEaGnh (ORCPT ); Sun, 31 May 2015 02:43:37 -0400 Date: Sun, 31 May 2015 15:41:14 +0900 From: Greg KH To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Subject: Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion Message-ID: <20150531064114.GB7057@kroah.com> References: <1433054248-22239-1-git-send-email-kys@microsoft.com> <1433054269-22278-1-git-send-email-kys@microsoft.com> <1433054269-22278-3-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433054269-22278-3-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2015 at 11:37:49PM -0700, K. Y. Srinivasan wrote: > Allocate ring buffer memory from the NUMA node assigned to the channel. But you do more than just that. If there's a failure, you fall-back to the old allocation method. Why not mention that as well? And is that what you really want? Do we ever fail allocation for a node but still have memory from another one? Shouldn't the logic be in the allocator and not be forced to be in every caller? thanks, greg k-h