From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbbFAKDZ (ORCPT ); Mon, 1 Jun 2015 06:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52455 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753316AbbFAKCE (ORCPT ); Mon, 1 Jun 2015 06:02:04 -0400 Date: Mon, 1 Jun 2015 12:01:56 +0200 From: Jiri Olsa To: Andi Kleen Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , Paul Mackerras , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile Message-ID: <20150601100156.GB19893@krava.redhat.com> References: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432761809-4344-5-git-send-email-sukadev@linux.vnet.ibm.com> <20150528124221.GK12392@krava.redhat.com> <20150529054506.GA3088@us.ibm.com> <20150529091140.GA20512@krava.redhat.com> <20150530054927.GB1187@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150530054927.GB1187@tassilo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote: > On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: > > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > > > Jiri Olsa [jolsa@redhat.com] wrote: > > > | > if (line[0] == '#' || line[0] == '\n') > > > | > continue; > > > | > + if (!strncmp(line, "Family", 6)) > > > | > + continue; > > > | > > > | I think we should fix mapfiles to put the 'Family' starting > > > | line as a comment.. the way powerpc mapfile is done > > > > > > You mean add something like this to the Intel mapfile: > > > > > > # Power8 entries > > > 004d0100,1,power8.json,core > > > > > > and drop this patch? > > > > right > > But it's a CSV file. CSV files are supposed to have column headers. > There are lots of tools that work better with them if they have headers. header could be behind '#' > Please keep the header. hum, do all arch start with 'Family' column? I guess not, so eventualy we will need to add first column of each arch in here? ending up with list of 'keywords' which we ignore or let's just ignore first line? I'd rather go with just one comment char and place the header behind it jirka