From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbbFAQKA (ORCPT ); Mon, 1 Jun 2015 12:10:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36837 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbFAQJw (ORCPT ); Mon, 1 Jun 2015 12:09:52 -0400 Date: Mon, 1 Jun 2015 18:09:50 +0200 From: Jan Kara To: kernel@kyup.com Cc: jack@suse.cz, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsnotify: Remove obsolete documentation Message-ID: <20150601160950.GA11971@quack.suse.cz> References: <1433164240-10504-1-git-send-email-kernel@kyup.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433164240-10504-1-git-send-email-kernel@kyup.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 01-06-15 16:10:40, kernel@kyup.com wrote: > From: Nikolay Borisov > > should_send_event is no longer part of struct fsnotify_ops > so remove it > > Signed-off-by: Nikolay Borisov Right. You can add: Reviewed-by: Jan Kara Honza > --- > include/linux/fsnotify_backend.h | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h > index 0f313f9..65a517d 100644 > --- a/include/linux/fsnotify_backend.h > +++ b/include/linux/fsnotify_backend.h > @@ -84,8 +84,6 @@ struct fsnotify_fname; > * Each group much define these ops. The fsnotify infrastructure will call > * these operations for each relevant group. > * > - * should_send_event - given a group, inode, and mask this function determines > - * if the group is interested in this event. > * handle_event - main call for a group to handle an fs event > * free_group_priv - called when a group refcnt hits 0 to clean up the private union > * freeing_mark - called when a mark is being destroyed for some reason. The group > -- > 1.7.1 > -- Jan Kara SUSE Labs, CR