From: Jeremiah Mahler <jmmahler@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel <fuse-devel@lists.sourceforge.net>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fuse: avoid clobbering fc->release with fuse_conn_init(fc)
Date: Mon, 1 Jun 2015 10:28:43 -0700 [thread overview]
Message-ID: <20150601172843.GA24635@hudson.localdomain> (raw)
In-Reply-To: <CAJfpegstSBEqu5QO1qWAsuoQAGUBXf3RmrKXg0P3oRiZ9EQfeA@mail.gmail.com>
Miklos,
On Mon, Jun 01, 2015 at 02:03:02PM +0200, Miklos Szeredi wrote:
> On Mon, Jun 1, 2015 at 3:31 AM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> > fuse_conn_init(fc) zeros the entire fc structure before it assigns
> > specific values. Since fc->release is set before fuse_conn_init(fc)
> > is called, the value gets set to zero, which results in a NULL pointer
> > deference when fc->release() is called. Fix the problem by assigning
> > fc->release after calling fuse_conn_init(fc) instead of before.
>
> I added this fix to the original patch and force pushed to
> fuse.git/for-next. Better keep it in one so that your fix is not left
> out accidentally when being backported to -stable.
>
> Thanks,
> Miklos
>
Good idea, thanks :-)
--
- Jeremiah Mahler
prev parent reply other threads:[~2015-06-01 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 8:03 BUG: update-grub, unable to handle kernel NULL pointer dereference Jeremiah Mahler
2015-05-31 23:52 ` Jeremiah Mahler
2015-06-01 1:31 ` [PATCH] fuse: avoid clobbering fc->release with fuse_conn_init(fc) Jeremiah Mahler
2015-06-01 12:03 ` Miklos Szeredi
2015-06-01 17:28 ` Jeremiah Mahler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601172843.GA24635@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®