From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932205AbbFBJN4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Jun 2015 05:13:56 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52576 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754762AbbFBJNm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Jun 2015 05:13:42 -0400
Date: Tue, 2 Jun 2015 11:13:40 +0200
From: Petr Mladek <pmladek@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Make the output better readable
Message-ID: <20150602091340.GJ3135@pathway.suse.cz>
References: <1433168737-17009-1-git-send-email-pmladek@suse.cz>
 <1433173824.4861.8.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433173824.4861.8.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 2015-06-01 08:50:24, Joe Perches wrote:
> On Mon, 2015-06-01 at 16:25 +0200, Petr Mladek wrote:
> > I always have troubles to parse checkpatch.pl output when I check
> > the whole patchset. It is hard to say which messages belongs to
> > what patch.
> > 
> > This patch does few small changes to make the output look better
> > for me:
> > 
> >     + delimit each patch from each other with dashes and empty line
> >     + remove empty line after the summary
> 
> I've no objection about this, but don't much care either.
> 
> >     + print message about false positives only once
> 
> This bit seems sensible, thanks.
> 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -720,8 +720,14 @@ my @fixed_deleted = ();
> >  my $fixlinenr = -1;
> >  
> >  my $vname;
> > +my $filenum = 0;
> >  for my $filename (@ARGV) {
> >  	my $FILE;
> > +
> > +	if ($filenum++ && $quiet == 0) {
> > +		print "--------------------------------------------------------------------------------\n";
> 
> Perhaps more perlish would be print '-' x 81 . '\n\n';
> Dunno why you chose 81 though, it seems an unusual number.

Are you sure, please? I have just counted it again and I see 80
dashes. Is it possible that you counted the initial quotation
mark '"'?

Well, I do not mind about the number of dashes. Feel free to update
it in case you merge it.

Thanks a lot for review.

Best Regards,
Petr