mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	pmladek@suse.cz
Subject: Re: [PATCH] livepatch: add module locking around kallsyms calls
Date: Tue, 2 Jun 2015 10:09:15 -0500	[thread overview]
Message-ID: <20150602150915.GB24773@treble.redhat.com> (raw)
In-Reply-To: <1433173717-20885-1-git-send-email-mbenes@suse.cz>

On Mon, Jun 01, 2015 at 05:48:37PM +0200, Miroslav Benes wrote:
> The list of loaded modules is walked through in
> module_kallsyms_on_each_symbol (called by kallsyms_on_each_symbol). The
> module_mutex lock should be acquired to prevent potential corruptions
> in the list.
> 
> This was uncovered with new lockdep asserts in module code introduced by
> the commit 0be964be0d45 ("module: Sanitize RCU usage and locking") in
> recent next- trees.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Thanks!

Should we add a comment to kallsyms_on_each_symbol() so that others
don't make this mistake?

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

  parent reply	other threads:[~2015-06-02 15:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 15:48 Miroslav Benes
2015-06-02  2:52 ` Minfei Huang
2015-06-02  9:15   ` Miroslav Benes
2015-06-02 10:06     ` Minfei Huang
2015-06-02 15:09 ` Josh Poimboeuf [this message]
2015-06-02 20:58   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602150915.GB24773@treble.redhat.com \
    --to=jpoimboe@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.cz \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®