From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760045AbbFBSPa (ORCPT ); Tue, 2 Jun 2015 14:15:30 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39468 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760014AbbFBSPT (ORCPT ); Tue, 2 Jun 2015 14:15:19 -0400 Date: Tue, 2 Jun 2015 19:15:13 +0100 From: Mark Brown To: Nariman Poushin Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20150602181512.GC14071@sirena.org.uk> References: <20150601092012.GA31354@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uWA6ivsFTdIbDdzo" Content-Disposition: inline In-Reply-To: <20150601092012.GA31354@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uWA6ivsFTdIbDdzo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 01, 2015 at 10:20:12AM +0100, Nariman Poushin wrote: > it be accepted), should I: > - Squash all the updates in to this patch (I suppose the benefit > there is that we don't break the kernel build from one patch > to the other) You need to squash the changes in since they break bisection if handled separately. It would be better to do this by having a separate patch to add the newly named structure rather than adding the new functionality at the same time. That makes the patch more mechanical and easier to review. --uWA6ivsFTdIbDdzo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVbfKwAAoJECTWi3JdVIfQ5eYIAIa3HPRyJmGxatVoJ3hIi9jX XXFxyulkYk8UG2VPl2Qe+rFH7YjeDg7sZpmhev+QRbSc+cfWasUWiWPEOEGMlRoQ wqmKlLtjQjndP2lF+W/5V6D7hNOZ6/m3v3VF5h3hL4h0STgeB+uDwvT+EOc09x9l bUmwL41D8zR4aSI6NK6x/kOAYrLaioY78Hs0ZTzn+XTvabL6d6P8UvNjtEygEGJK K6633wFISPxU2fr7Mm5jne3RxrNKKZf+C71DbWmxHAXkcJErmTOYwzLJtWzL/rZj xcXVJmscg/TcwrYbWEOo6grIseI2TnYmT1WdQzpIz5WYj91ZsflQWMOlNxKO2Ss= =6f5M -----END PGP SIGNATURE----- --uWA6ivsFTdIbDdzo--