From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbbFDDVu (ORCPT ); Wed, 3 Jun 2015 23:21:50 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43639 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbFDDVk (ORCPT ); Wed, 3 Jun 2015 23:21:40 -0400 Date: Wed, 03 Jun 2015 20:21:39 -0700 (PDT) Message-Id: <20150603.202139.67164973308592314.davem@davemloft.net> To: linux@rasmusvillemoes.dk Cc: grundler@parisc-linux.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tulip: rearrange order of searching for substrings From: David Miller In-Reply-To: <1433331843-32301-1-git-send-email-linux@rasmusvillemoes.dk> References: <1433331843-32301-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 03 Jun 2015 20:21:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Wed, 3 Jun 2015 13:44:03 +0200 > Currently, two of the branches are dead code, since an earlier smaller > substring would have been found ("TP" in the "TP_NW" case and either > of "BNC" and "AUI" in the "BNC_AUI" case). Rearrange the strstr() > calls so that the longer strings are searched for first. > > Signed-off-by: Rasmus Villemoes Applied to net-next, thank you.