From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbFDSnK (ORCPT ); Thu, 4 Jun 2015 14:43:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49148 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbbFDSnI (ORCPT ); Thu, 4 Jun 2015 14:43:08 -0400 Date: Thu, 04 Jun 2015 11:43:07 -0700 (PDT) Message-Id: <20150604.114307.1604949989982148476.davem@davemloft.net> To: julien.grall@citrix.com Cc: joe@perches.com, xen-devel@lists.xenproject.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses From: David Miller In-Reply-To: <5570484C.8040201@citrix.com> References: <1433350510-12846-2-git-send-email-julien.grall@citrix.com> <1433351196.4861.131.camel@perches.com> <5570484C.8040201@citrix.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Jun 2015 11:43:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julien Grall Date: Thu, 4 Jun 2015 13:45:00 +0100 > On 03/06/15 18:06, Joe Perches wrote: >> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: >>> rx->status is an int16_t, print it using %d rather than %u in order to >>> have a meaningful value when the field is negative. >> [] >>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> [] >>> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue, >>> if (unlikely(rx->status < 0 || >>> rx->offset + rx->status > PAGE_SIZE)) { >>> if (net_ratelimit()) >>> - dev_warn(dev, "rx->offset: %x, size: %u\n", >>> + dev_warn(dev, "rx->offset: %x, size: %d\n", >> >> If you're going to do this, perhaps it'd be sensible to >> also change the %x to %#x or 0x%x so that people don't >> mistake offset without an [a-f] for decimal. > > Good idea. I will resend a version of this series. > > David, can I keep you Reviewed-by for this change? Sure.