From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbbFDJk7 (ORCPT ); Thu, 4 Jun 2015 05:40:59 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44871 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbbFDJkw (ORCPT ); Thu, 4 Jun 2015 05:40:52 -0400 Date: Thu, 4 Jun 2015 11:40:43 +0200 From: Peter Zijlstra To: Fengguang Wu Cc: Frederic Weisbecker , Ingo Molnar , kpreempt-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org, LKP Subject: Re: [sched/preempt] BUG: kernel boot crashed Message-ID: <20150604094043.GF3644@twins.programming.kicks-ass.net> References: <20150604045536.GB30151@wfg-t540p.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150604045536.GB30151@wfg-t540p.sh.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2015 at 12:55:36PM +0800, Fengguang Wu wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > commit b30f0e3ffedfa52b1d67a302ae5860c49998e5e2 > Author: Frederic Weisbecker > AuthorDate: Tue May 12 16:41:49 2015 +0200 > Commit: Ingo Molnar > CommitDate: Tue May 19 08:39:12 2015 +0200 > > sched/preempt: Optimize preemption operations on __schedule() callers > > __schedule() disables preemption and some of its callers > (the preempt_schedule*() family) also set PREEMPT_ACTIVE. > > So we have two preempt_count() modifications that could be performed > at once. > > Lets remove the preemption disablement from __schedule() and pull > this responsibility to its callers in order to optimize preempt_count() > operations in a single place. > > Suggested-by: Linus Torvalds > Signed-off-by: Frederic Weisbecker > Signed-off-by: Peter Zijlstra (Intel) > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Link: http://lkml.kernel.org/r/1431441711-29753-5-git-send-email-fweisbec@gmail.com > Signed-off-by: Ingo Molnar Frederic said that he was working on the issue and we should expect patches shortly.