mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG, bisect] hrtimer: severe lag after suspend & resume
Date: Thu, 4 Jun 2015 13:13:08 -0700	[thread overview]
Message-ID: <20150604201308.GA1335@hudson.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.11.1506041319580.7118@nanos>

Thomas,

On Thu, Jun 04, 2015 at 01:22:45PM +0200, Thomas Gleixner wrote:
> On Wed, 3 Jun 2015, Jeremiah Mahler wrote:
[...]
> 
> I had to wrap my head around that for quite a while, but I think I
> have decoded the issue. Can you please test the patch below whether it
> solves your problem?
> 
> Thanks,
> 
> 	tglx
> 
> ------------------------>
> 
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> index 278d4b36fd94..e9dfcd0b8c41 100644
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -1492,6 +1492,12 @@ static void init_hrtimers_cpu(int cpu)
>  
>  	cpu_base->cpu = cpu;
>  	hrtimer_init_hres(cpu_base);
> +	/*
> +	 * Force an update by setting the clock was set sequence to an
> +	 * odd value.
> +	 */
> +	cpu_base->clock_was_set_seq = 1;
> +	hrtimer_update_base(cpu_base);
>  }
>  
>  #ifdef CONFIG_HOTPLUG_CPU
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 90ed5db67c1d..c97710137a9e 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -593,7 +593,7 @@ static void timekeeping_update(struct timekeeper *tk, unsigned int action)
>  	update_fast_timekeeper(&tk->tkr_raw,  &tk_fast_raw);
>  
>  	if (action & TK_CLOCK_WAS_SET)
> -		tk->clock_was_set_seq++;
> +		tk->clock_was_set_seq += 2;
>  }
>  
>  /**

With this change it won't boot.  It just hangs at "Booting the kernel".

-- 
- Jeremiah Mahler

  reply	other threads:[~2015-06-04 20:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04  0:56 Jeremiah Mahler
2015-06-04 11:22 ` Thomas Gleixner
2015-06-04 20:13   ` Jeremiah Mahler [this message]
2015-06-04 22:54 ` John Stultz
2015-06-05  0:01   ` Jeremiah Mahler
2015-06-05  7:57   ` Ingo Molnar
2015-06-05  9:14   ` Thomas Gleixner
2015-06-05 10:07     ` Ingo Molnar
2015-06-05 18:52       ` John Stultz
2015-06-08  7:44         ` Thomas Gleixner
2015-06-08 17:37           ` John Stultz
2015-06-08 19:31             ` Thomas Gleixner
2015-06-05 14:02     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604201308.GA1335@hudson.localdomain \
    --to=jmmahler@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®