From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754206AbbFELuF (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Jun 2015 07:50:05 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:41130 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751376AbbFELuB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Jun 2015 07:50:01 -0400
Date: Fri, 5 Jun 2015 20:49:58 +0900
From: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: "'Kay Sievers'" <kay@vrfy.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] driver: core: add uid gid to class devnode
Message-ID: <20150605114958.GB12012@kroah.com>
References: <00eb01d09f77$d4f2c930$7ed85b90$@samsung.com>
 <20150605101916.GA3802@kroah.com>
 <016301d09f80$f33c4cf0$d9b4e6d0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <016301d09f80$f33c4cf0$d9b4e6d0$@samsung.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 05, 2015 at 08:15:37PM +0900, Namjae Jeon wrote:
> > On Fri, Jun 05, 2015 at 07:10:21PM +0900, Namjae Jeon wrote:
> > > Add support for setting uid gid to devtmpfs device nodes.
> > > In this manner, drivers can specify desired uid gid in their
> > > class->devnode method.
> > >
> > > This is extension of existing method of setting uid gid by drivers
> > > using device_type->devnode method:
> > > 3c2670e6515cf584810f417db9b00992c8b2d75a
> > > "driver core: add uid and gid to devtmpfs"
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
> > 
> > You add new parameters to these functions, yet never use them.  Sorry, I
> > need an actual user before I can accept api changes like this.
> > 
> > Same for the other 2 patches in this series, I can't accept api changes
> > without a real user of them, otherwise I'll just have to rip them out
> > again to simplify the code.
> Hi Greg,
> 
> In closed embedded systems like Tizen or Android, It is needed to set
> uid/gid and xattr without shell script and daemon like udevd.
> This api change can make it easier to set these parameters

And exactly how will that happen?  I don't see a user of these changes
in the kernel, so I can't accept it, sorry.

greg k-h