From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbbFHCWK (ORCPT ); Sun, 7 Jun 2015 22:22:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbFHCWG (ORCPT ); Sun, 7 Jun 2015 22:22:06 -0400 Date: Sun, 07 Jun 2015 19:22:02 -0700 (PDT) Message-Id: <20150607.192202.705812138482774611.davem@davemloft.net> To: jonas.jensen@gmail.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: moxa: fix TX overrun memory leak From: David Miller In-Reply-To: <1433511978-17666-1-git-send-email-jonas.jensen@gmail.com> References: <1433511978-17666-1-git-send-email-jonas.jensen@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 07 Jun 2015 19:22:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonas Jensen Date: Fri, 5 Jun 2015 15:46:18 +0200 > desc = priv->tx_desc_base + (TX_REG_DESC_SIZE * tx_head); > > - spin_lock_irq(&priv->txlock); > + if (CIRC_SPACE(tx_head, tx_tail, TX_DESC_NUM) == 0) { > + priv->stats.tx_dropped++; > + goto out_unlock; > + } You can't do this. Whatever code creates this condition _must_ stop the TX queue so that the core netdevice transmit layer does not call your transmit method.