From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbbFHPuA (ORCPT ); Mon, 8 Jun 2015 11:50:00 -0400 Received: from smtprelay0250.hostedemail.com ([216.40.44.250]:35071 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751278AbbFHPtu (ORCPT ); Mon, 8 Jun 2015 11:49:50 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3870:4321:4385:5007:6119:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12114:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: push15_55c4a5f04351d X-Filterd-Recvd-Size: 2203 Date: Mon, 8 Jun 2015 11:49:48 -0400 From: Steven Rostedt To: Rasmus Villemoes Cc: Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [RFC/PATCH 2/8] kernel/trace/trace_events_filter.c: Use strreplace Message-ID: <20150608114948.1b37a6a8@gandalf.local.home> In-Reply-To: <1433410636-26812-3-git-send-email-linux@rasmusvillemoes.dk> References: <1433410636-26812-1-git-send-email-linux@rasmusvillemoes.dk> <1433410636-26812-3-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Jun 2015 11:37:09 +0200 Rasmus Villemoes wrote: > There's no point in starting over every time we see a ','... > > Signed-off-by: Rasmus Villemoes > --- > kernel/trace/trace_events_filter.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index ced69da0ff55..a987601d7b43 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -2075,7 +2075,7 @@ struct function_filter_data { > static char ** > ftrace_function_filter_re(char *buf, int len, int *count) > { > - char *str, *sep, **re; > + char *str, **re; > > str = kstrndup(buf, len, GFP_KERNEL); > if (!str) > @@ -2085,8 +2085,7 @@ ftrace_function_filter_re(char *buf, int len, int *count) > * The argv_split function takes white space > * as a separator, so convert ',' into spaces. > */ > - while ((sep = strchr(str, ','))) > - *sep = ' '; > + strreplace(str, ',', ' '); Acked-by: Steven Rostedt -- Steve > > re = argv_split(GFP_KERNEL, str, count); > kfree(str);