From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933006AbbFHOBq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Jun 2015 10:01:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35408 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932841AbbFHN6u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Jun 2015 09:58:50 -0400
Date: Mon, 8 Jun 2015 15:58:43 +0200
From: Milos Vyletel <milos@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@kernel.org>, Don Zickus <dzickus@redhat.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
        "open list:PERFORMANCE EVENT..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: avoid possible race condition in copyfile
Message-ID: <20150608135843.GA2026@lenivo.usersys.redhat.com>
References: <1433407453-28739-1-git-send-email-milos@redhat.com>
 <20150604091100.GA19775@gmail.com>
 <20150608133957.GB3136@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150608133957.GB3136@kernel.org>
Organization: Red Hat Czech s.r.o.
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 08, 2015 at 10:39:57AM -0300, Arnaldo Carvalho de Melo wrote:

> Em Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar escreveu:
> > * Milos Vyletel <milos@redhat.com> wrote:
> > > On top of that slow_copyfile no longer needs to deal with file mode when
> > > creating file since temporary file is already created and mode is set.
> > > 
> > > Signed-off-by: Milos Vyletel <milos@redhat.com>
> > 
> > Ok, that looks nice!
> > 
> > Assuming it passes testing you can add my ack to it:
> > 
> >   Acked-by: Ingo Molnar <mingo@kernel.org>
> 
> Can you please try applying it on tip/perf/core instead? I think it is
> clashing with:
> 
> commit 9c9f5a2f1944e8b6bf2b618d04b31e1c1760637e
> Author: Namhyung Kim <namhyung@kernel.org>
> Date:   Mon May 18 09:30:18 2015 +0900
> 
>     perf tools: Introduce copyfile_offset() function
> 

And also with 

commit 0b1de0be1eac7b23e89cb43c17b02d38ead6b6c8
Author: Namhyung Kim <namhyung@kernel.org>
Date:   Mon May 18 09:30:17 2015 +0900

    perf tools: Add rm_rf() utility function

Will resend version based on tip/perf/core after I rerun my testing.

Milos