From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbbFHRZF (ORCPT ); Mon, 8 Jun 2015 13:25:05 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48754 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbbFHRY7 (ORCPT ); Mon, 8 Jun 2015 13:24:59 -0400 Date: Mon, 8 Jun 2015 18:24:51 +0100 From: Mark Brown To: Nariman Poushin Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20150608172451.GJ14071@sirena.org.uk> References: <20150508095537.GA15394@opensource.wolfsonmicro.com> <20150508102019.GX22845@sirena.org.uk> <20150508103454.GA13160@opensource.wolfsonmicro.com> <20150608141641.GA9236@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lw/GBiv4LoRdT+hF" Content-Disposition: inline In-Reply-To: <20150608141641.GA9236@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Lw/GBiv4LoRdT+hF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 08, 2015 at 03:16:41PM +0100, Nariman Poushin wrote: > In light of this: > https://lkml.org/lkml/2015/6/7/193 Please provide human readable descriptions for things, people don't always read online and it at least means going to another program to figure out what's being discussed. > Would it be prudent to now make these WARN_ON? It seems like it's not > worth taking the kernel down in the case where you are trying to sync to > a non-existent cache for a peripheral. Of course it could be that the=20 This is nothing new on Linus' part, really - as he himself says. We're being cautious here because we are often controlling devices like PMICs and battery chargers where we're worried about physically damaging the system if we get things too wrong, one thing that might possibly have been happening here is that we've got very confused about what we're doing with a critical system component. There's certainly a case for having some handling that's less severe but it does need to be something that people notice and which is conservative about interacting with the device after it noticed the problem. In any case, if you want to propose a code change then please submit a patch. --Lw/GBiv4LoRdT+hF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVdc/jAAoJECTWi3JdVIfQZLMH+wXPSc1lucJKgPh7LuI8jEwF uo0k5AwkEBo0Q0xq/goTTRaSgO/Ph7ZPi/vi0wB51E4AQWkV8hiDBF+iei9gIwQk 6Vw6OMQ0u2RZ8d008vmju2nZPuQiXYMXJxaasQoXCR7RymimkHGo5QLiWGO00dMa rHxM3I8gTFb5K8Kxj2RN+bMfehouuq2McK8qS1kliMlsjltoJmRt8j2Qx7BGARxB WfIVm2mDl8ZEq6QqZNQ85gqOJ813/lgPN/ydYKhQnckvbW4YuW8qPKeApbP0IMNc 59hIZzTWbxRbUdsvUvASQ6aPFIN3e4gj1uKhhs4LQKWrKxCC18ptvcVavEMxyRo= =OmmN -----END PGP SIGNATURE----- --Lw/GBiv4LoRdT+hF--