From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbbFHSHc (ORCPT ); Mon, 8 Jun 2015 14:07:32 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48835 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbbFHSH0 (ORCPT ); Mon, 8 Jun 2015 14:07:26 -0400 Date: Mon, 8 Jun 2015 19:07:18 +0100 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Message-ID: <20150608180718.GR14071@sirena.org.uk> References: <1433529771-24496-1-git-send-email-lee.jones@linaro.org> <1433529771-24496-6-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Epdev7n9Nu0o9kVy" Content-Disposition: inline In-Reply-To: <1433529771-24496-6-git-send-email-lee.jones@linaro.org> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Epdev7n9Nu0o9kVy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2015 at 07:42:48PM +0100, Lee Jones wrote: > Perhaps this is just personal preference, but ... Possibly... > Prevents this kind of nonsense: > this->is->just.silly = fetch_silly_value(&pointer); > if (!this->is->just.silly) { > printk("Silly value failed: %d\n", this->is->just.silly); > return this->is->just.silly; > } But we don't have any of that code? Well, one if statement where we check config.init_data but that's it. A temporary does help with things like the above but we're not doing that in this driver are we? --Epdev7n9Nu0o9kVy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVddnWAAoJECTWi3JdVIfQnzEH/107IEjPBMoJaPFki+LmRjkR rtOJI6YAdVh6nYvbX5rkqA/4cgbYQc4kwSgQqT2pnWj5ZF9t2MyQ34JmZwldsAIT 75oZRgJHimTN6JmSxS9KexcGn295Ft1Cw9cjDVkkqIWTl0aI28/KKvxtcHPAZNno tVwDYoJhrVpGKl0YXAlNm6n6ya/5Q47j1s6BLOdNckKxg+stTjkQzEaHkx994K2Q xnR4HtzSPwU23/HOKk/TfYHDd9oA/l4+1vVV1mMuvLS4ECO5qvRtghs/P/muNxNs RAd2Li2RHHUQ88rMjeTwHcY0e47U2agn2kb21DPHnWuCiUgmAcQoXwCn0pyFx2c= =YNrQ -----END PGP SIGNATURE----- --Epdev7n9Nu0o9kVy--