From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"mdcasey@chabloom.com" <mdcasey@chabloom.com>,
"behanw@converseincode.com" <behanw@converseincode.com>,
"mateusz.kulikowski@gmail.com" <mateusz.kulikowski@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness
Date: Mon, 8 Jun 2015 13:41:53 -0700 [thread overview]
Message-ID: <20150608204153.GA17791@kroah.com> (raw)
In-Reply-To: <20150602160156.GA20704@visteon-gnana>
On Tue, Jun 02, 2015 at 03:59:32PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal <gdhanapa@visteon.com>
>
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
>
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> ---
> v3: Greg review comments addressed
>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 9dce121..a842170 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1265,7 +1265,7 @@ inline struct sk_buff *rtllib_association_req(struct rtllib_network *beacon,
> skb_put(skb, sizeof(struct rtllib_assoc_request_frame) + 2);
>
>
> - hdr->header.frame_ctl = RTLLIB_STYPE_ASSOC_REQ;
> + hdr->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_ASSOC_REQ);
> hdr->header.duration_id = cpu_to_le16(37);
> ether_addr_copy(hdr->header.addr1, beacon->bssid);
> ether_addr_copy(hdr->header.addr2, ieee->dev->dev_addr);
> @@ -2244,8 +2244,10 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
> struct rtllib_assoc_response_frame *assoc_resp;
> struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data;
>
> + u16 frame_ctl = le16_to_cpu(header->frame_ctl);
> +
Why the blank line before this variable definition?
prev parent reply other threads:[~2015-06-08 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 15:59 DHANAPAL, GNANACHANDRAN (G.)
2015-06-08 20:41 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608204153.GA17791@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=behanw@converseincode.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdhanapa@visteon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=mdcasey@chabloom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®