From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbbFIErf (ORCPT ); Tue, 9 Jun 2015 00:47:35 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:35127 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbbFIEr0 (ORCPT ); Tue, 9 Jun 2015 00:47:26 -0400 Date: Tue, 9 Jun 2015 12:46:46 +0800 From: Herbert Xu To: Guenter Roeck Cc: Stephan Mueller , Peter Zijlstra , Andy Shevchenko , Jim Davis , Stephen Rothwell , Linux-Next , linux-kernel@vger.kernel.org, "David S. Miller" , linux-crypto@vger.kernel.org, Waiman Long , Ingo Molnar , x86 Subject: nios2: Export get_cycles Message-ID: <20150609044646.GA6892@gondor.apana.org.au> References: <3181127.KGS6GDHCq6@tachyon.chronox.de> <55766C3A.3070101@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55766C3A.3070101@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2015 at 09:31:54PM -0700, Guenter Roeck wrote: > > nios2 still fails to build with > > ERROR: "get_cycles" [crypto/jitterentropy.ko] undefined! It's the only arch that doesn't inline get_cycles and doesn't export it. ---8<--- nios2 is the only architecture that does not inline get_cycles and does not export it. This breaks crypto as it uses get_cycles in a number of modules. Reported-by: Guenter Roeck Signed-off-by: Herbert Xu diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c index 7f45474..be186a7 100644 --- a/arch/nios2/kernel/time.c +++ b/arch/nios2/kernel/time.c @@ -8,6 +8,7 @@ * for more details. */ +#include #include #include #include @@ -106,6 +107,7 @@ cycles_t get_cycles(void) { return nios2_timer_read(&nios2_cs.cs); } +EXPORT_SYMBOL(get_cycles); static void nios2_timer_start(struct nios2_timer *timer) { -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt