From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612AbbFIKKY (ORCPT ); Tue, 9 Jun 2015 06:10:24 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49841 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbFIKKQ (ORCPT ); Tue, 9 Jun 2015 06:10:16 -0400 Date: Tue, 9 Jun 2015 11:10:05 +0100 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Message-ID: <20150609101005.GZ14071@sirena.org.uk> References: <1433529771-24496-1-git-send-email-lee.jones@linaro.org> <1433529771-24496-6-git-send-email-lee.jones@linaro.org> <20150608180718.GR14071@sirena.org.uk> <20150609070347.GE2982@x1> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ukxq3d9/SFe4Ri4s" Content-Disposition: inline In-Reply-To: <20150609070347.GE2982@x1> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ukxq3d9/SFe4Ri4s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote: > Admittedly this is an extreme example, but I do consider: > init_data = of_get_regulator_init_data(); > if (init_data) > return -ENOMEM; > ... neater than: > config.init_data = of_get_regulator_init_data(); > if (!config.init_data) > return -ENOMEM; Oh, I see. I pretty much see things the other way for things where the temporary has no other users. --ukxq3d9/SFe4Ri4s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVdrt8AAoJECTWi3JdVIfQ+LEH/0TvmZDkUVLSy+hea3kJyo/y PNiGl+B+QGKaSpA8bwCt1Xy9Joq2p8nnuShjpjyqjd2FjqLCSsWVl+8oHD3kBF4E miSeM5fbnfomXJAdhrHfyFYR/ZNOKTAUwximzehkITvI54SUVPtuCDxZ6Zw5je70 PO8sNCdU114r8Gue/HPUz4YLcNlaKrJpXhauzrnM0TRgHUV5n9y149OX/uY5TgDQ qd6iPAhwwaGQQQBeuOP9U5Uk+Zd+eialps7/1HhpnmYhmw87qtLiEivGVv0+20OB hwFSEWkYLS6Jb9f+NJsL/S3qJRhI7S8mSkkB/fPU5WMFEUjk+g61mksVj6HqMa8= =pXnE -----END PGP SIGNATURE----- --ukxq3d9/SFe4Ri4s--