From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932270AbbFINY6 (ORCPT ); Tue, 9 Jun 2015 09:24:58 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:57435 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbbFINYu (ORCPT ); Tue, 9 Jun 2015 09:24:50 -0400 Date: Tue, 9 Jun 2015 21:24:38 +0800 From: Herbert Xu To: Stephan Mueller Cc: Ted Tso , andreas.steffen@strongswan.org, sandyinchina@gmail.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] crypto: drbg - Use callback API for random readiness Message-ID: <20150609132438.GA12946@gondor.apana.org.au> References: <20150609101830.GA10521@gondor.apana.org.au> <3448831.Xm980FM7Uq@tachyon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3448831.Xm980FM7Uq@tachyon.chronox.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 02:23:39PM +0200, Stephan Mueller wrote: > > I am wondering about the error here. The Jitter RNG has in its init function a > test to see whether the RNG really works on the hardware as there are still > systems out there that have no high-res timer (e.g. I have seen that on old > Android phones). If the Jitter RNG detects that the system is not appropriate, > it will not register. If we have no jent and the pool isn't ready then we should at least fail in FIPS mode. If we weren't in FIPS mode we could block but for now I'm going to go with the current behaviour of simply continuing. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt