From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DRM: Armada: fixup wait_event_timeout being ignored
Date: Wed, 10 Jun 2015 12:22:36 +0100 [thread overview]
Message-ID: <20150610112235.GL7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1433934428-21980-1-git-send-email-hofrat@osadl.org>
On Wed, Jun 10, 2015 at 01:07:08PM +0200, Nicholas Mc Guire wrote:
> The calling side seems to assume 0 as success and <0 as error so
> returning -ETIME should be fine here.
The idea here is to allow the remainder of the code to execute when
the condition succeeds _or_ times out. If it times out, that is
not a failure - it merely means that the display has been blanked
and we're not seeing frame done interrupts anymore.
The code should not be checking the returned value at all - in fact
I have updates to this code which (in part) remove this, and fix a
glaring problem that the wait queue is never woken.
I wonder how many places you've made this same mistake... please
ensure that you review the code you're changing carefully.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-06-10 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 11:07 Nicholas Mc Guire
2015-06-10 11:22 ` Russell King - ARM Linux [this message]
2015-06-10 11:48 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610112235.GL7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome