From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933760AbbFJTo7 (ORCPT ); Wed, 10 Jun 2015 15:44:59 -0400 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:46017 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932742AbbFJTow (ORCPT ); Wed, 10 Jun 2015 15:44:52 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3870:3871:4321:4362:4605:5007:6261:7875:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12114:12296:12438:12517:12519:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: kick34_477cb1ca0334b X-Filterd-Recvd-Size: 1522 Date: Wed, 10 Jun 2015 15:44:50 -0400 From: Steven Rostedt To: Wang Long Cc: , , , Subject: Re: [PATCH] ring-buffer-benchmark: Fix the wrong param in module_param Message-ID: <20150610154450.108e33c4@gandalf.local.home> In-Reply-To: <1433923873-67712-1-git-send-email-long.wanglong@huawei.com> References: <1433923873-67712-1-git-send-email-long.wanglong@huawei.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Jun 2015 08:11:13 +0000 Wang Long wrote: > The {producer|consumer}_{nice|fifo} parameters are integer > type, we should use 'int' as the second param in module_param. > > For example(consumer_fifo): > the default value of consumer_fifo is -1. > Without this patch: > # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo > 4294967295 > With this patch: > # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo > -1 > > Signed-off-by: Wang Long > --- Thanks, Applied! -- Steve