From: Steven Rostedt <rostedt@goodmis.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
"CC: Ingo Molnar" <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, "x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test
Date: Wed, 10 Jun 2015 18:36:56 -0400 [thread overview]
Message-ID: <20150610183656.6adeedb6@gandalf.local.home> (raw)
In-Reply-To: <55789AFE.80408@redhat.com>
On Wed, 10 Jun 2015 22:15:58 +0200
Denys Vlasenko <dvlasenk@redhat.com> wrote:
> On 06/10/2015 10:00 PM, Kees Cook wrote:
> >> + printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
> >> + exit(0); /* this is not a test failure */
> >
> > Why is that not a test failure? It would mean it didn't actually test
> > anything, which seems like a failure to me.
>
> Are you objecting to comment wording, or to exiting with 0?
>
> I exit with 0 because no bug was detected.
I believe there's a way to exit with "not supported". That's what the
ftrace tests do.
-- Steve
prev parent reply other threads:[~2015-06-10 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:59 Denys Vlasenko
2015-06-10 20:00 ` Kees Cook
[not found] ` <55789AFE.80408@redhat.com>
2015-06-10 20:20 ` Kees Cook
2015-06-10 22:36 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610183656.6adeedb6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=shuahkh@osg.samsung.com \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®