From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbbFKFwl (ORCPT ); Thu, 11 Jun 2015 01:52:41 -0400 Received: from mail-pd0-f194.google.com ([209.85.192.194]:36252 "EHLO mail-pd0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbFKFwd (ORCPT ); Thu, 11 Jun 2015 01:52:33 -0400 X-Greylist: delayed 681 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Jun 2015 01:52:33 EDT Date: Thu, 11 Jun 2015 11:22:27 +0530 From: Vaishali Thakkar To: linux-kernel@vger.kernel.org Cc: Julia Lawall Subject: [PATCH] Drivers: block: Use setup_timer Message-ID: <20150611055227.GA6771@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, a; @@ -init_timer(&e1); +setup_timer(&e1, a, 0UL); ... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/block/umem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 4cf81b5..cd999a1 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -738,8 +738,7 @@ static void check_all_batteries(unsigned long ptr) static void init_battery_timer(void) { - init_timer(&battery_timer); - battery_timer.function = check_all_batteries; + setup_timer(&battery_timer, check_all_batteries, 0UL); battery_timer.expires = jiffies + (HZ * 60); add_timer(&battery_timer); } -- 1.9.1