From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbFLCqF (ORCPT ); Thu, 11 Jun 2015 22:46:05 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:51077 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbbFLCqB (ORCPT ); Thu, 11 Jun 2015 22:46:01 -0400 Date: Fri, 12 Jun 2015 10:45:49 +0800 From: Herbert Xu To: Stephan Mueller Cc: Tadeusz Struk , linux-kernel@vger.kernel.org, keescook@chromium.org, jwboyer@redhat.com, richard@nod.at, steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com, linux-crypto@vger.kernel.org, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com Subject: Re: [PATCH RFC v4 2/4] crypto: add PKE API Message-ID: <20150612024549.GA31228@gondor.apana.org.au> References: <20150611190533.31826.13956.stgit@tstruk-mobl1> <20150611190543.31826.357.stgit@tstruk-mobl1> <2901639.xlpED6EpBc@tauon.atsec.com> <20150612024246.GA30982@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150612024246.GA30982@gondor.apana.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 10:42:46AM +0800, Herbert Xu wrote: > On Fri, Jun 12, 2015 at 03:00:42AM +0200, Stephan Mueller wrote: > > > > The testmgr code can mark an entire cipher implementation as fips_allowed=1 as > > already done for RSA. However, unlike with the other ciphers, that flag must > > go in conjunction with the used key sizes. > > > > For FIPS mode, the following restrictions apply: > > > > - RSA: 2048/3072 > > > > - DSA: L 2048 / N 224; L 2048 / N 256; L 3072 / N 256 > > > > - ECDSA: only the NIST curves > > > > Any other key sizes for the given ciphers is not allowed in FIPS mode. > > > > Should that constraint be considered here? > > Yes. However it should be placed into a helper that everybody > can call so that future hardware implementations can also make > the same checks. Ugh I didn't notice this was the generic API setkey function. No it should go into the algorithm-specific setkey function and then be in the form of a helper so that all implementations of that algorithm can call it. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt