From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751050AbbFLE3J (ORCPT ); Fri, 12 Jun 2015 00:29:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36053 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbFLE3H (ORCPT ); Fri, 12 Jun 2015 00:29:07 -0400 Date: Thu, 11 Jun 2015 21:29:06 -0700 From: Greg KH To: Chanwoo Choi Cc: balbi@ti.com, myungjoo.ham@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type Message-ID: <20150612042906.GB10691@kroah.com> References: <1434075006-2931-1-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434075006-2931-1-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote: > This patch just redefine the unique id of supported external connectors without > 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to > indicate the specific external connectors like key number of input framework. > So, I have the plan to move this definitions to following header file which > includes the unique id of supported external connectors. > - include/dt-bindings/extcon/extcon.h Do we have other such fields in dt-bindings that are not enumerated types? What's wrong with keeping this as-is and not changing to an integer? > Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string") How is this a bugfix? confused, greg k-h