mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
	"Borislav Petkov" <bp@suse.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Len Brown" <lenb@kernel.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"X86 ML" <x86@kernel.org>,
	"Fengguang Wu" <fengguang.wu@intel.com>,
	"Aaron Lu" <aaron.lu@intel.com>,
	"Suravee Suthikulanit" <suravee.suthikulpanit@amd.com>,
	"Tony Li" <tony.li@amd.com>, "Ken Xue" <ken.xue@amd.com>
Subject: Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer
Date: Fri, 12 Jun 2015 15:50:33 +0800	[thread overview]
Message-ID: <20150612075033.GA24767@hr-slim.amd.com> (raw)
In-Reply-To: <20150612073848.GQ3644@twins.programming.kicks-ass.net>

On Fri, Jun 12, 2015 at 09:38:48AM +0200, Peter Zijlstra wrote:
> On Fri, Jun 12, 2015 at 12:03:22PM +0800, Huang Rui wrote:
> 
> > > What's the purpose of the "enable" parameter?
> > > 
> > 
> > Enable mwaitx timer. Should I add comments to explain the usage?
> 
> No, you should read your own patch, notice that the only usage site
> provides a true, then realize its a redundant bit of code and kill it
> dead.

Yeah, but I remembered at last time, someone tell me we shouldn't
force to set timer always enabled. So I add this interface to expose
more clearly. :)

So could I use __mwaitx directly like below:

__monitorx(&dummy, 0, 0);
__mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE);


Thanks,
Rui

  reply	other threads:[~2015-06-12  8:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 14:14 [PATCH v3 0/2] x86, mwaitt: introduce AMD mwaitt support Huang Rui
2015-06-11 14:14 ` [PATCH v3 1/2] x86, mwaitt: add monitorx and mwaitx instruction Huang Rui
2015-06-11 14:19   ` Borislav Petkov
2015-06-11 14:14     ` Huang Rui
2015-06-11 14:14 ` [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer Huang Rui
2015-06-11 17:34   ` Andy Lutomirski
2015-06-12  4:03     ` Huang Rui
2015-06-12  7:38       ` Peter Zijlstra
2015-06-12  7:50         ` Huang Rui [this message]
2015-06-12  8:30           ` Borislav Petkov
2015-06-12  8:23             ` Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612075033.GA24767@hr-slim.amd.com \
    --to=ray.huang@amd.com \
    --cc=aaron.lu@intel.com \
    --cc=bp@suse.de \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=ken.xue@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=tony.li@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®