From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753622AbbFLUn3 (ORCPT ); Fri, 12 Jun 2015 16:43:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34895 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbbFLUn2 (ORCPT ); Fri, 12 Jun 2015 16:43:28 -0400 Date: Fri, 12 Jun 2015 13:43:27 -0700 From: Greg KH To: julien.dehee@gmail.com Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, tapaswenipathak@gmail.com, hamohammed.sa@gmail.com, viro@zeniv.linux.org.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes Message-ID: <20150612204327.GB1410@kroah.com> References: <1434140438-57879-1-git-send-email-julien.dehee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434140438-57879-1-git-send-email-julien.dehee@gmail.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee@gmail.com wrote: > From: Julien Dehee > > comedi/comedi_fops.c > use ENODEV following open manual > > comedi/drivers.c > use ENOTTY following ioctl manual > > drivers/serial2002.c > use ENOTTY following ioctl manual What do you mean by "ioctl manual"? And shouldn't this be 3 different patches as they do different things to different drivers? thanks, greg k-h