From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbbFLVGg (ORCPT ); Fri, 12 Jun 2015 17:06:36 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:36482 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFLVGf (ORCPT ); Fri, 12 Jun 2015 17:06:35 -0400 Date: Fri, 12 Jun 2015 22:06:16 +0100 From: One Thousand Gnomes To: Greg KH Cc: julien.dehee@gmail.com, abbotti@mev.co.uk, hsweeten@visionengravers.com, tapaswenipathak@gmail.com, hamohammed.sa@gmail.com, viro@zeniv.linux.org.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes Message-ID: <20150612220616.14fdd5b7@lxorguk.ukuu.org.uk> In-Reply-To: <20150612204327.GB1410@kroah.com> References: <1434140438-57879-1-git-send-email-julien.dehee@gmail.com> <20150612204327.GB1410@kroah.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2015 13:43:27 -0700 Greg KH wrote: > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee@gmail.com wrote: > > From: Julien Dehee > > > > comedi/comedi_fops.c > > use ENODEV following open manual That should probably be ENXIO by a strict reading, but Linux has always used ENODEV 8) > > > > comedi/drivers.c > > use ENOTTY following ioctl manual > > > > drivers/serial2002.c > > use ENOTTY following ioctl manual > > What do you mean by "ioctl manual"? man 2 ioctl Unknown ioctls on a device should error with ENOTTY. It's one of those crazy pieces of Unix history.