mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Sergej Sawazki <ce3a@gmx.de>
Cc: gregkh@linuxfoundation.org, w.sang@pengutronix.de,
	wsa@the-dreams.de, linux-kernel@vger.kernel.org
Subject: Re: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151
Date: Mon, 15 Jun 2015 10:49:22 +0100	[thread overview]
Message-ID: <20150615094922.GB18309@sirena.org.uk> (raw)
In-Reply-To: <557C2E3E.80000@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

On Sat, Jun 13, 2015 at 03:21:02PM +0200, Sergej Sawazki wrote:

> when I try to read the register values of a i2c ASoC codec through
> debugfs, (eg: cat /sys/kernel/debug/regmap/1-001a/registers)
> I am getting an WARN_ON at drivers/base/regmap/regmap-debugfs.c:151.

Please provide some plain text description of which line of code you're
referring to when reporting things - line numbers do change as things
move on (though I see this one).

> I did some debugging and found that regmap_readable(), at regmap-
> debugfs.c:109, returns "false" for all registers, hence the
> debugfs_off_cache list remains empty and we get an warning in line 151.

We need to change that code to special case write only register maps
like this and just skip having a cache for those devices.  They normally
have very small register maps anyway so it shouldn't have too big an
impact on performance.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-06-15  9:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13 13:21 Sergej Sawazki
2015-06-15  9:49 ` Mark Brown [this message]
2015-06-15 12:42   ` Sergej Sawazki
2015-06-15 14:49     ` Mark Brown
2015-06-24 20:49       ` Sergej Sawazki
2015-07-07 22:42         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615094922.GB18309@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ce3a@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®