From: Herbert Xu <herbert@gondor.apana.org.au>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [RESEND PATCH v4 04/14] crypto: add a new driver for Marvell's CESA
Date: Mon, 15 Jun 2015 17:54:21 +0800 [thread overview]
Message-ID: <20150615095421.GA32158@gondor.apana.org.au> (raw)
In-Reply-To: <1434093366-14681-5-git-send-email-boris.brezillon@free-electrons.com>
On Fri, Jun 12, 2015 at 09:15:56AM +0200, Boris Brezillon wrote:
>
> +static int mv_cesa_cbc_aes_op(struct ablkcipher_request *req,
> + struct mv_cesa_op_ctx *tmpl)
> +{
> + mv_cesa_update_op_cfg(tmpl, CESA_SA_DESC_CFG_CRYPTCM_CBC,
> + CESA_SA_DESC_CFG_CRYPTCM_MSK);
> + memcpy(tmpl->ctx.blkcipher.iv, req->info, 16);
You need to copy the IV back into req->info after completion.
Incidentally we don't seem to test for output IVs in our self-
test so bugs like this can slip through until someone tries to
do chaining with it. That's something worth adding to testmgr.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-06-15 9:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 7:15 [RESEND PATCH v4 00/14] " Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 01/14] crypto: mv_cesa: document the clocks property Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 02/14] crypto: mv_cesa: use gen_pool to reserve the SRAM memory region Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 03/14] crypto: mv_cesa: explicitly define kirkwood and dove compatible strings Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 04/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-15 9:37 ` Herbert Xu
2015-06-15 11:39 ` Boris Brezillon
2015-06-15 9:48 ` Herbert Xu
2015-06-15 11:38 ` Boris Brezillon
2015-06-15 12:40 ` Herbert Xu
2015-06-15 9:54 ` Herbert Xu [this message]
2015-06-15 11:31 ` Boris Brezillon
2015-06-15 12:38 ` Herbert Xu
2015-06-15 9:59 ` Herbert Xu
2015-06-15 11:26 ` Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 05/14] crypto: marvell/CESA: add TDMA support Boris Brezillon
2015-06-15 10:09 ` Herbert Xu
2015-06-15 11:25 ` Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 06/14] crypto: marvell/CESA: add DES support Boris Brezillon
2015-06-12 7:15 ` [RESEND PATCH v4 07/14] crypto: marvell/CESA: add Triple-DES support Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 08/14] crypto: marvell/CESA: add MD5 support Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 09/14] crypto: marvell/CESA: add SHA256 support Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 10/14] crypto: marvell/CESA: add support for all armada SoCs Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 11/14] crypto: marvell/CESA: add allhwsupport module parameter Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 12/14] crypto: marvell/CESA: add support for Orion SoCs Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 13/14] crypto: marvell/CESA: add support for Kirkwood and Dove SoCs Boris Brezillon
2015-06-12 7:16 ` [RESEND PATCH v4 14/14] crypto: marvell/CESA: add DT bindings documentation Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615095421.GA32158@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®