From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbbFOMnv (ORCPT ); Mon, 15 Jun 2015 08:43:51 -0400 Received: from mail-by2on0138.outbound.protection.outlook.com ([207.46.100.138]:46442 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753861AbbFOMnn (ORCPT ); Mon, 15 Jun 2015 08:43:43 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; amacapital.net; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NPZKOR-07-3MM-02 X-M-MSG: Date: Mon, 15 Jun 2015 20:42:58 +0800 From: Huang Rui To: Peter Zijlstra CC: Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , , , Fengguang Wu , Aaron Lu , Suravee Suthikulanit , Tony Li , Ken Xue Subject: Re: [PATCH v5 1/2] x86, mwaitt: add monitorx and mwaitx instruction Message-ID: <20150615124257.GA28310@hr-slim.amd.com> References: <1434365284-1495-1-git-send-email-ray.huang@amd.com> <1434365284-1495-2-git-send-email-ray.huang@amd.com> <20150615105542.GV3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150615105542.GV3644@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11OLC003;1:KXXzYa0eveOclgPnb5+7qkox3rx2/kaUK750aH4o6I57FRi70ctHzIQ87LmqFso9jQ3R6ejqCudgUQVMsoGAltyNCRn2KgWIx0Li4FvZMnzkG9qeGFI7d5ARZTEMjHcRqpxz951bqlHWc2M2CkQ/GZwb567HmJ2XufJuzFiWJZ6CxMsIWuq78sCYFDfItMS2HaxaatAKlSKAi5JAZ3TBtrJafS1Q+TBDpmOoTHCoF8Bfa5//i+t41xt2gWuyIk1abLouXl7GYdfWCgL+B57Fsw2RkgBYAmGeyjy//V74gk2SzWEyuUimv6+3chU9A6C2jgslsSKDoIWzFfFeCrXnVSHKRzrMaJIjFJmyRluihuU= X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(199003)(164054003)(189002)(24454002)(23726002)(97756001)(19580395003)(87936001)(50466002)(47776003)(62966003)(77156002)(86362001)(106466001)(83506001)(5003600100002)(105586002)(50986999)(33656002)(53416004)(46406003)(110136002)(46102003)(92566002)(189998001)(77096005)(101416001)(54356999)(4001350100001)(2950100001)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB250;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB250;2:c4pipvYuvecBFE9I1tvmZtMulSBxdKsV1LaXKF+0XbxRvq5YvPmOMmigrict0oj8;2:9WvnF/LQN/TObqO/O0LlPYBxKWBCMhLUemeIfdGZNa1PAhUkvHWkCanJ9qrxyZo9SfHe3Ruz0Nx7FBu6pUugM87G6qJkHOKjAI3h/VqYn1N48AhWP5hJAxzuAKZQSiEPKRz4yb/oj+TuX+IRHrG3BBjGfK0hZpDUTmEDe9ZYEPJlImvmGXegq2QUd+LOI6zx8oaLgoOj4A17W8IOKU3ZeFcwet48YHzfeQ0Lht4VBZWqL+dwxZw23XyQzXzmae/a;6:jCtBTas0EukP7MDzZ4ix6kTlGMR3iF1sEwdh7R5b7mqmZp2gRmizQmkwOKB/6Mkjvo++tnTClT+zGQAM8fW0o8K+4AHJWzoTFzgFep2OmFJkvkzA9gfj8fefJ6VXvYrBEwA+1OJ0Oa9+Jzlfi1+4g4rzohXo9TI7oJAlKhtMJZCxJVCzNlGgfy/hvxNou52ndeB/NH1JV/Oq1YRO0dgZ9MmlqKyb9SkDMpAEzoqU+TbVIHDD30cXBHxhKT+QTCkWMpXXcW8sRPC63CTgpflLLQXOe08kL7WEE8OGeorA5P/EUI5sq+jHELDXS9YCR8se62U0S6eveEyvjw0nqIG0MIZb6qGcx7W/tSRKE+IbPPiDh5JSRLbgqJrc3Wn4p8vbLLT6x8Vka/BL5YEr8zwLojsKvZdfVtWo3X/sKfo6eHcLWQzzNJEvD1q0Pn+rLB9ELq5qIdGrF19BC/hAv4ABlrzYwv7CAQySqSY9fhr615jg85sB/WiGe0Vk0go61Odd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB250; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY2PR02MB250;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB250; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB250;3:rggiJu4bYPCq6qESeurnomIk5Y+l+vxPopoD+Jcm3+DE/9mf/muTck4xhs6ejyw6SSIVKMHFJns6v1/VcPzaLj+kUoHlZgXR2Ce7IItfIwkJWGq2YUGqRL9LaNjDG0Ti2Gtp/LDGHE1K9Ki+kSF2Hf7rBiHWGP3Io0dNeSpr2o9fA0wG91x3K3czOL33tpi7MCwU8KzqYX3y7GznnUZMm+5EYWMhVJyQGJrRxJJP7xwDla1d9I3JUcTvNZWeW9PqI8Qq/eMbnW1JV40AkDZs3XV3NLhcuDczYF3up/lDjPHgsatQdl5Cndl53yPpcMCO X-Forefront-PRVS: 0608DEDB67 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB250;9:VpZC8O1bGCKXK3gOA9RiiN4J7oi7hpOTSGSg3hrV7tLQrYDyXgYOGk4R2ljVk4lmeoghIZrb1RnBESn7ZN8/hgW5N3dA7JMOxSJ8IcFlOdOl9W00Y4+29IH1xtKBUAK33m1C0z2t20+OHopIbZDmEN58W1791vowdsCk2uCL5MsZfoR3bMT5Qz21VOHDHRSW0KqmB7WFhjwbfMfSSSXQb9qG+3S/BAeYfAX+aNeQXmKMQRzU7wm/cYd6HSiinl167ztnHcyUwzM6tMWy4VbDTlPwHYmfx1umhfPTVLRymQn/BTeCcX1ZvgL6ujSdP2Ue8r73D/TKdpNzoUVPdMX2mGekb7rR9jiAlMgcTqhwXIHYO3QD3VxKkl4BHnOPsGapihwUxFB5k+vYcvBxAZsNHZuQe0FPP2zn+UdGuSZy5Rep1AqlQzZNb47GG30asT52+WnQUOuG2boeEaGQfQWzayIHg3r1hSwg9mvDL7Y5DWQBtA0YmRB0cPvdlLi6IJXunH2lkqV6jUhVhi2zIfsF5YlfqA7GfM5y6at9s34RfnAVzuVmv2RnQBVMq+2HbdZUoqN2wJpDnjG+Fd07lcW521ZTpCCj0JT/vMgKCKfutq2+fDUtiHUj/ztjqxZJp0x+cMqNNz32Mhyh/wJrgh0kEaSLtD4yuh9JfPhfwA/y/ywi2hWXfbfe6LizyrBkYaMT6o1iesOXsEk61lu/IHvmqbNFF3T+8LZkZTGHH9GjYCod+x4JZcawuB9aEsJYHNDZVTzS897cPyDj6+8rw1cDiWSX0Mcdqy4opvC7PuWbKWI/0VxRbuidQZkXgtuOpynPb/j5kzLGKWYPRyO169vLShdm0jVNCY4Px1Cl5lNFdBrRGO1WdNWnqkc0rRuTHQHj X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB250;3:f5Kwqv/SVJP0r/puxBbxjQCJ4DIeEhJ3karm3lFStVDr4tekIUf8CHYTWQWMXTzSs+25934fjQUbKb7rIDHvl5fAC2GKCTDs7aBRpanB94a6roTPdZxqV1ufZKSH/g7ingtRoAPsmfCtUMkjWYWE/A==;10:lFcM1id7Vl+uNFgfCFQHZsbieY818ESm//fqkehdKC6bQ3zd9fkB4m6ijJQ+piUts4ME2NVEkTvqQ2kqXtjsZ585L65+NKlXQIfY90by9gQ=;6:YSmRCNXbb6qlALSYjeeN4MyzBicjNKYdUMR79jedppX3CRFFIPpxrjXWYWU6IaPj X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2015 12:43:41.0243 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 12:55:42PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2015 at 06:48:03PM +0800, Huang Rui wrote: > > +/* > > + * MWAITT allows for both a timer value to get you out of the MWAIT as > > + * well as the normal exit conditions. > > + * > > + * MWAITX ECX[1]: enable timer if set > > + * MWAITX EBX[31:0]: max wait time expressed in SW P0 clocks > > + * > > + * Below is the compared data between MWAIT and MWAITX on AMD > > + * processors: > > + * MWAIT MWAITX > > + * opcode 0f 01 c9 | 0f 01 fb > > + * ECX[0] value of RFLAGS.IF seen by instruction > > + * ECX[1] unused/#GP if set | enable timer if set > > + * ECX[31:2] unused/#GP if set > > + * EAX unused (reserve for hint) > > Seeing how you're stuffing a !0 value in here in the next patch, the > above comment seems slightly incorrect, no? > That's because current processor doesn't support to go C1 state. The next patch use the hint is to avoid core go to C1 state in future processor. Thanks, Rui