From: kbuild test robot <fengguang.wu@intel.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: kbuild-all@01.org, Lee Jones <lee.jones@linaro.org>,
Dmitry Torokhov <dtor@chromium.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH ljones-mfd] mfd: cros_ec:: ec_p can be static
Date: Mon, 15 Jun 2015 21:39:39 +0800 [thread overview]
Message-ID: <20150615133939.GA240231@ivytown2> (raw)
In-Reply-To: <201506152112.lboOYuQR%fengguang.wu@intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cros_ec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index 11b1884b..dd6f4ff 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -27,7 +27,7 @@
#define CROS_EC_DEV_EC_INDEX 0
#define CROS_EC_DEV_PD_INDEX 1
-struct cros_ec_platform ec_p = {
+static struct cros_ec_platform ec_p = {
.ec_name = CROS_EC_DEV_NAME,
.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_EC_INDEX),
};
@@ -37,13 +37,13 @@ struct cros_ec_platform pd_p = {
.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX),
};
-struct mfd_cell ec_cell = {
+static struct mfd_cell ec_cell = {
.name = "cros-ec-ctl",
.platform_data = &ec_p,
.pdata_size = sizeof(ec_p),
};
-struct mfd_cell ec_pd_cell = {
+static struct mfd_cell ec_pd_cell = {
.name = "cros-ec-ctl",
.platform_data = &pd_p,
.pdata_size = sizeof(pd_p),
next prev parent reply other threads:[~2015-06-15 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 13:39 [ljones-mfd:ib-mfd-i2c-input-chrome-4.2 8/10] drivers/mfd/cros_ec.c:30:25: sparse: symbol 'ec_p' was not declared. Should it be static? kbuild test robot
2015-06-15 13:39 ` kbuild test robot [this message]
2015-06-15 19:06 ` [PATCH ljones-mfd] mfd: cros_ec:: ec_p can be static Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615133939.GA240231@ivytown2 \
--to=fengguang.wu@intel.com \
--cc=dtor@chromium.org \
--cc=gwendal@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®