mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Borislav Petkov" <bp@suse.de>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Len Brown" <lenb@kernel.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	"Fengguang Wu" <fengguang.wu@intel.com>,
	"Aaron Lu" <aaron.lu@intel.com>,
	"Suravee Suthikulanit" <suravee.suthikulpanit@amd.com>,
	"Tony Li" <tony.li@amd.com>, "Ken Xue" <ken.xue@amd.com>
Subject: Re: [PATCH v5 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer
Date: Mon, 15 Jun 2015 22:14:59 +0800	[thread overview]
Message-ID: <20150615141458.GC28310@hr-slim.amd.com> (raw)
In-Reply-To: <20150615105718.GW3644@twins.programming.kicks-ass.net>

On Mon, Jun 15, 2015 at 12:57:18PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 15, 2015 at 06:48:04PM +0800, Huang Rui wrote:
> > diff --git a/arch/x86/include/asm/mwait.h b/arch/x86/include/asm/mwait.h
> > index 1fbc89d..47f3540 100644
> > --- a/arch/x86/include/asm/mwait.h
> > +++ b/arch/x86/include/asm/mwait.h
> > @@ -14,6 +14,9 @@
> >  #define CPUID5_ECX_INTERRUPT_BREAK	0x2
> >  
> >  #define MWAIT_ECX_INTERRUPT_BREAK	0x1
> > +#define MWAITX_ECX_TIMER_ENABLE		BIT(1)
> > +#define MWAITX_MAX_LOOPS		((u32)-1)
> > +#define MWAITX_DISABLE_CSTATES		0xf
> >  
> >  static inline void __monitor(const void *eax, unsigned long ecx,
> >  			     unsigned long edx)
> 
> Should this hunk not be part of the previous patch?
> 

This definitions are used to implement delay function, so I put it at
this patch. :)

Thanks,
Rui

      parent reply	other threads:[~2015-06-15 14:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 10:48 [PATCH v5 0/2] x86, mwaitt: introduce AMD mwaitt support Huang Rui
2015-06-15 10:48 ` [PATCH v5 1/2] x86, mwaitt: add monitorx and mwaitx instruction Huang Rui
2015-06-15 10:55   ` Peter Zijlstra
2015-06-15 12:42     ` Huang Rui
2015-06-15 10:48 ` [PATCH v5 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer Huang Rui
2015-06-15 10:57   ` Peter Zijlstra
2015-06-15 11:15     ` Borislav Petkov
2015-06-15 14:04       ` Huang Rui
2015-06-15 14:25         ` Borislav Petkov
2015-06-15 14:33           ` Huang Rui
2015-06-15 14:14     ` Huang Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615141458.GC28310@hr-slim.amd.com \
    --to=ray.huang@amd.com \
    --cc=aaron.lu@intel.com \
    --cc=bp@suse.de \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=ken.xue@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=tony.li@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®