From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: linux-kernel@vger.kernel.org, keescook@chromium.org,
jwboyer@redhat.com, smueller@chronox.de, richard@nod.at,
steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com,
linux-crypto@vger.kernel.org, james.l.morris@oracle.com,
jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net,
vgoyal@redhat.com
Subject: Re: [PATCH RFC v5 2/4] crypto: add PKE API
Date: Tue, 16 Jun 2015 10:27:51 +0800 [thread overview]
Message-ID: <20150616022751.GA19040@gondor.apana.org.au> (raw)
In-Reply-To: <557F83DF.2090003@intel.com>
On Mon, Jun 15, 2015 at 07:03:11PM -0700, Tadeusz Struk wrote:
> On 06/15/2015 05:05 PM, Herbert Xu wrote:
> >> > + * @setkey: Function invokes the algorithm specific set key function, which
> >> > + * knows how to decode and interpret the BER encoded key
> > We should split this into two functions: setpubkey and setprivkey.
> >
>
> The two functions will be almost identical. We can do it this way if we want to check
> if all the required elements of the key are provided. Currently I'm checking this in the
> actual operation.
Right now your RSA setkey function only works if you supply both
the public key and the private key. If the user supplies only one
key how are you going to tell whether it's public or private?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-06-16 2:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 20:18 [PATCH RFC v5 0/4] crypto: Introduce Public Key Encryption API Tadeusz Struk
2015-06-15 20:18 ` [PATCH RFC v5 1/4] MPILIB: add mpi_read_buf() and mpi_get_size() helpers Tadeusz Struk
2015-06-16 6:40 ` Herbert Xu
2015-06-15 20:18 ` [PATCH RFC v5 2/4] crypto: add PKE API Tadeusz Struk
2015-06-15 23:46 ` Herbert Xu
2015-06-15 23:49 ` Herbert Xu
2015-06-15 23:50 ` Herbert Xu
2015-06-15 23:54 ` Herbert Xu
2015-06-15 23:59 ` Herbert Xu
2015-06-16 2:21 ` Tadeusz Struk
2015-06-16 2:29 ` Herbert Xu
2015-06-16 2:46 ` Tadeusz Struk
2015-06-16 2:50 ` Herbert Xu
2015-06-16 2:55 ` Tadeusz Struk
2015-06-16 0:05 ` Herbert Xu
2015-06-16 2:03 ` Tadeusz Struk
2015-06-16 2:27 ` Herbert Xu [this message]
2015-06-16 2:41 ` Tadeusz Struk
2015-06-16 3:25 ` Herbert Xu
2015-06-16 3:36 ` Tadeusz Struk
2015-06-16 4:06 ` Herbert Xu
2015-06-16 4:48 ` Tadeusz Struk
2015-06-16 2:29 ` Tadeusz Struk
2015-06-16 2:32 ` Herbert Xu
2015-06-15 20:18 ` [PATCH RFC v5 3/4] crypto: rsa: add a new rsa generic implementation Tadeusz Struk
2015-06-15 23:23 ` Stephan Mueller
2015-06-16 1:49 ` Tadeusz Struk
2015-06-16 2:19 ` Stephan Mueller
2015-06-16 2:26 ` Tadeusz Struk
2015-06-15 20:18 ` [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Tadeusz Struk
2015-06-16 0:37 ` Herbert Xu
2015-06-16 6:26 ` Tadeusz Struk
2015-06-16 6:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616022751.GA19040@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=richard@nod.at \
--cc=smueller@chronox.de \
--cc=steved@redhat.com \
--cc=tadeusz.struk@intel.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®