From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754461AbbFQLSG (ORCPT ); Wed, 17 Jun 2015 07:18:06 -0400 Received: from smtp.citrix.com ([66.165.176.89]:37800 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbbFQLSD (ORCPT ); Wed, 17 Jun 2015 07:18:03 -0400 X-IronPort-AV: E=Sophos;i="5.13,632,1427760000"; d="scan'208";a="272814321" Date: Wed, 17 Jun 2015 12:10:46 +0100 From: Wei Liu To: Nicholas Krause CC: , , , , Subject: Re: [PATCH] xen-netback:Make the function xenvif_schedulable have a return type of bool Message-ID: <20150617111046.GG1813@zion.uk.xensource.com> References: <1434510210-1341-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1434510210-1341-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2015 at 11:03:30PM -0400, Nicholas Krause wrote: > This makes the function xenvif_sechedulable have a return type of > bool now due to this particular function's return statement only > ever evaluating to have a value of one or zero. > > Signed-off-by: Nicholas Krause Acked-by: Wei Liu > --- > drivers/net/xen-netback/common.h | 2 +- > drivers/net/xen-netback/interface.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h > index 8a495b3..c02cafb 100644 > --- a/drivers/net/xen-netback/common.h > +++ b/drivers/net/xen-netback/common.h > @@ -280,7 +280,7 @@ void xenvif_free(struct xenvif *vif); > int xenvif_xenbus_init(void); > void xenvif_xenbus_fini(void); > > -int xenvif_schedulable(struct xenvif *vif); > +bool xenvif_schedulable(struct xenvif *vif); > > int xenvif_queue_stopped(struct xenvif_queue *queue); > void xenvif_wake_queue(struct xenvif_queue *queue); > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index 1a83e19..b5fcb52 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -63,7 +63,7 @@ void xenvif_skb_zerocopy_complete(struct xenvif_queue *queue) > atomic_dec(&queue->inflight_packets); > } > > -int xenvif_schedulable(struct xenvif *vif) > +bool xenvif_schedulable(struct xenvif *vif) > { > return netif_running(vif->dev) && > test_bit(VIF_STATUS_CONNECTED, &vif->status) && > -- > 2.1.4