From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757478AbbFQSrY (ORCPT ); Wed, 17 Jun 2015 14:47:24 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:40520 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756251AbbFQSrQ (ORCPT ); Wed, 17 Jun 2015 14:47:16 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3154:3353:3622:3865:3867:3868:3870:3871:3872:3873:3874:5007:6120:6261:7514:7875:8531:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: steam34_78cc32929825f X-Filterd-Recvd-Size: 2966 Date: Wed, 17 Jun 2015 14:47:09 -0400 From: Steven Rostedt To: Cong Wang Cc: Peter Zijlstra , Mathieu Desnoyers , LKML , Thomas Gleixner , Ingo Molnar , Francis Giraldeau , lttng-dev , Linus Torvalds Subject: Re: [RFC PATCH] sched: Fix sched_wakeup tracepoint Message-ID: <20150617144709.5814a48d@gandalf.local.home> In-Reply-To: References: <1433504509-17013-1-git-send-email-mathieu.desnoyers@efficios.com> <20150605120909.GG19282@twins.programming.kicks-ass.net> <479621151.4836.1433507522491.JavaMail.zimbra@efficios.com> <1433508695.1495.16.camel@twins> <600031664.4911.1433510581646.JavaMail.zimbra@efficios.com> <1433592142.1495.22.camel@twins> <1960877063.5553.1433672414640.JavaMail.zimbra@efficios.com> <20150608132735.0763ad27@gandalf.local.home> <20150609091336.GQ3644@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jun 2015 11:23:00 -0700 Cong Wang wrote: > On Tue, Jun 9, 2015 at 2:13 AM, Peter Zijlstra wrote: > > > > So how about we introduce the 'waking' tracepoint and leave the existing > > wakeup one in place and preserve its woken semantics. > > > > Steven, can we do aliases? Where one tracepoint is known to userspace > > under multiple names? In that case we could rename the thing to woken > > and have an alias wakeup which we can phase out over time. > > > > The patch also takes away the success parameter to the tracepoint, but > > does not quite go as far as actually removing it from the tracepoint > > itself. > > > > We can do that in a follow up patch which we can quickly revert if it > > turns out people are actually still using that for something. > > +1 to this patch. How is it going? It's not a top priority. But it shouldn't be too hard to implement. This could be something I do after the 4.2 merge window closes. -- Steve > > Here at Twitter, we are analyzing scheduling latencies too, with our > own tool using existing tracepoints, it would be nice to have more > granularity on the scheduling latency. > > And, you probably want to change perf sched to respect this > new 'waking' event too. ;) > > Thanks.