From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbbFQQH5 (ORCPT ); Wed, 17 Jun 2015 12:07:57 -0400 Received: from mail-bn1on0078.outbound.protection.outlook.com ([157.56.110.78]:39139 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757180AbbFQQHt (ORCPT ); Wed, 17 Jun 2015 12:07:49 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Date: Wed, 17 Jun 2015 09:07:30 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Nicholas Krause CC: , , , , , Subject: Re: [PATCH] xilinx:Remove unused variable num_frag in the function axienet_start_xmit Message-ID: <20150617160730.GE2906@xsjsorenbubuntu> References: <1434556362-3748-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1434556362-3748-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21618.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD025;1:mNWitsnkDCmsGMJvKwrgpr5jhXPe9fXrp4FPTHSBlbcsoly3/mLZHq6KLAwlgSLmuGxBy5x0m2PGZAQA7An/rNOw7G2UrZqPG6oGLg+QF/70VWYtViLU5iJ64+VGgi9sWn8xdsGXfs5Fi7yq6zjoX2VaByBoeTDYynj8qPJQ+hqsYISpvgBXMkk0/tlMu6csK4QnWyx39YR/dXdBquwFvhHczaOw8/hn8cQpa7AEi9eZs/VApOpEpqCzU8Xowmlsi7yq/WFgwH0HbYAbIF06t/X3hW2IGoBCPdoeMVU/jH2g3EHSDzyOTqDe3TUuYNffC008eUmsk25CjI3YKpximQ== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(51704005)(377424004)(24454002)(189002)(33716001)(77156002)(19580405001)(83506001)(1411001)(47776003)(6806004)(110136002)(106466001)(85202003)(33656002)(5001960100002)(189998001)(62966003)(77096005)(36386004)(92566002)(4001350100001)(81156007)(86362001)(19580395003)(87936001)(85182001)(50986999)(76176999)(54356999)(23676002)(46102003)(2950100001)(57986006)(76506005)(50466002)(63266004)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB016;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:ovrnspm;A:1;MX:1;PTR:unknown-60-83.xilinx.com;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB016;2:n6KRfex9tQWa7HvqKBHeVixMoZZngAbM9bkGFa7mP9qq7Ic536usEzBkNcr3vEqq;2:nATOoDNUGnVgL+UzEsHj+5+BpO4bqqnF7mNtVnoMoLdIl5YCZ7J9qYa9aW98ENr+YEABh6iDZc1IQ5xyG99PV5X2CVacM3xTyIw93PirkziGn8g2B3vTHqx7XgQffdVktedBi/YmhfSQ+lCA4hDFn5TDjNBquWzvZIIblkoFxhI2CprclC+Be7fhtbZGZkS1pejDq7GG2QNWAC20Qh76bEPo/cEhBbChH6HoSxopeUs=;6:Ngf9N8IFuMbbYa1B5DwGxS5KreZQpXu+E6zjGU7Wrm25tPo94fRy3Qjh2bNULwg3AFruyyWTdoEQ7ECOcjWRyqlvdgulKT9dhyKf387u6oFWcn8ZauEcNb1yPdqeTjNIY0tjAZvg9guPGzdzj1wYd3zV1nnad7D4qsnSpkG6/qH4jSVGNEHjQWzBK3fUnvNTZl0WTFZBDsgHoUsn/lMZbud5ReANF8ilCwk/nTkeyz11JnQiAlTXHhttSjdA78KrO8faz/KDzCak11qqr/B0CYMwfWy3ZGhb/b70+K2TAj9HpuiT3cUdxNkdEOvQ+yu4AhmAke9fpU1He+ic/8MOKf6MrYPzRH5+O9pqG+yLeHkjrNatDtayGphonSJwF2c8JCA/HYX1pXOxB5EVU45o8pLsT54aL22xrS9XmVreHqtgZxECn4oGkDPUBZibKoNmMEuXciHqhGCIaV11ryANrPG6NeSUlk9JtSGiOO4oQviL3H1TSkjI5dKHI6nxm31L X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB016; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BL2FFO11HUB016;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB016; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB016;3:wemCwBbuiXbkXbEA+QTyBUJjJ8xZqM6sMIO03EbLVpXyjwiP2zS9UI4uRLwcjntuqtz4UTKZZDBIzc2QFTjrwHTuYqtVAB7GEOFDROaZ7goEPOUVUuY0RSLGLI8i2NNDCNU/kUeiYIj9d324WPLRhYclKoo7Fy/RIkwDnNmroSb291vl6c7DoH/yPl617WTzTKttUWK5ySlzabg5ptOqtf6EkdsNhnm/Tmo6Sk2p95mVSq7c9vglZgHintcafxGW7amVde1btX+Z8aXYh6ZxfAGWQjyC37+QTQQMhywex6hb6fZuby1kldSoSJS911xJ X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMUhVQjAxNjs5OkJOeEJKVmU2VjhKeGVQYnVoUllrUkpnUHNK?= =?utf-8?B?Z1oyVDllWjBROEhOVjZXTTFUVm0rdHI3NS90bEYzeFFVZUF6LzdaZzI2dGVa?= =?utf-8?B?STJ1UlRtbU43a3pkRjJJMVpVVEFJbXIxTXVWa3B2ckxZYnI4NGdSdTFtdXhn?= =?utf-8?B?MXM2RUNVWjJoNndhNWpLRXVVOXpaOGQ3bmVlb3lVcUFKaTRBUHRHeXhLaXMx?= =?utf-8?B?NklmN1o5TUFQWENVNFQ4V0Z6dWptM0tkb3I4d1U4cXEzMmNmcU9OemZTVGVW?= =?utf-8?B?SHVOWVJXYm8xSExZYWdzcStxc3RVSEVtekJSekNwbzVKb25aQW9UeUZqSS9u?= =?utf-8?B?RmlDRnpWb3J5aFgwK1lRaFNVSFpoS2dwOVVOU2Z4NHdMd1g5Y0FxVzR2L01r?= =?utf-8?B?VUhuNSthU1kreUV4cTV4dWNjY3UrbTFWRXgrczZUdlVpK0pBMmtlbEx5ei9l?= =?utf-8?B?TzcraUVBZUowUS83QU92ek93dllWUGZBbWZISysrTk9PN01FRVMrbDlJM2FB?= =?utf-8?B?RWF1ZFhXZnlCNnUwVE5EUUFCbElsNEFGWm9uYzByMGRwa3oxRENma0hlQzhk?= =?utf-8?B?SWpoZ3RIRlpjU1JRTTVoUW9MWjFyVXc5SnhydHdUSHZXazQvellRcFQyU1Zl?= =?utf-8?B?MWJKeGpTeGpTaGhpNmJ6SGFRWEFTaGZDS2JkU1pobUVCams3R201Q042SWNV?= =?utf-8?B?cFhTa1RXRWZodm02OGpwSkoyOVEzYU5hMXhUNHpCbHEzcGZFencxVXFCY2JE?= =?utf-8?B?OUduNXJMOEVmc2ZqcVB5bHFCajljYVZ4S0RNQ05JTzA4dEtCd0JSM25od2Jy?= =?utf-8?B?YjJVRE9PbnJhN1pXQnNlcWEyV1JyOFJJT3hMditOT1crdzFSTXlGeDdaSFdv?= =?utf-8?B?WlBVbHJXUEF2UDJNRmdhOEZ0TUh6SmNSU3dXS0VnRm15TWlVVzA3dVYrZ2xF?= =?utf-8?B?bjJHT0luTGJ0T0oxNUttR1JrMW5vNU82UUZpN0h6MGw3N0Vyc1ZyaGV6Z3A0?= =?utf-8?B?SlhRQWpMQ2Y5NENGNldhZVNMT0tkYUhoUHRuaVc2RW5GcG5BMkt4TjhidnVx?= =?utf-8?B?MDhHNDBhdU9xdjhBd3lOS1VRb0NDTXFwTnd6NUc0VXJzS3ZENExIYWJaSW10?= =?utf-8?B?WmlvVjBXMHNKVjA2SkwrK05UVnVLM3pHMjdVSGt0U1JEa1U1Snk0YzkwcWwv?= =?utf-8?B?QlJlN3N2ZWpKSHh6YktYNjBpV0hRNXQ0amNCSlo5MFAvaDdVam1QdXExWmNz?= =?utf-8?B?N1F4QWtPYkdQbG92enJiTUQxOW9DTllhUkpOc3RzWktkZnUvank1MlBqZS9B?= =?utf-8?B?TVlyWk5JZjNxbVpzTjFackVyZ2l0RDdRYVdpMzZrMENuMGJhdGZCL29XV0Zi?= =?utf-8?B?ZGh1L1hDWExzWkRhbHlsMDM2UG5oaUZnRU9YZVN1QThLOHBSKzZQeUd5KzJn?= =?utf-8?Q?3amuaQ9qVL1Fw7WZlW0wAX5dLst?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB016;3:ck+mJl2svHmuiN9fq3KhtvsCdF/4SZlpmSctihc1pW0+C7ObTuX6/337YQIinXxjjCO8usFKZi+P4hst6OKD4jU405aKrAimd8h7vwJpSFT5rcLihN7otpeefZ2dd8Ex3IyD2TcUqjGPiFQwX9EplQ==;10:TqJG3G8SKdgpcE812lA4SrSqjxaufpBq0+YJDmNp+tp4OzXDaQnEF7GCDJlzsBrkLd+vsXqGUUHMgln7TvqMRbLev/jfAkGMpQXtFayPwlg= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 16:07:38.0779 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB016 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-06-17 at 11:52AM -0400, Nicholas Krause wrote: > This removes the unused variable num_frag and the setting of it > to the number of fragments from the passed sk_buff pointer by > this function's caller due to this variable never being used > in this particular function and is not declared as global so > setting it for global use in this file is pointless. > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index 28b7e7d..624dce4 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -651,7 +651,6 @@ static inline int axienet_check_tx_bd_space(struct axienet_local *lp, > static int axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) > { > u32 ii; > - u32 num_frag; > u32 csum_start_off; > u32 csum_index_off; > skb_frag_t *frag; > @@ -659,7 +658,6 @@ static int axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) > struct axienet_local *lp = netdev_priv(ndev); > struct axidma_bd *cur_p; > > - num_frag = skb_shinfo(skb)->nr_frags; > cur_p = &lp->tx_bd_v[lp->tx_bd_tail]; > > if (axienet_check_tx_bd_space(lp, num_frag)) { It's used right here, isn't it (and further down in this function too)? Does your tree compile with this change? Sören