From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbbFQS7N (ORCPT ); Wed, 17 Jun 2015 14:59:13 -0400 Received: from mail-bn1on0090.outbound.protection.outlook.com ([157.56.110.90]:32801 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752484AbbFQS7C (ORCPT ); Wed, 17 Jun 2015 14:59:02 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Date: Wed, 17 Jun 2015 11:58:48 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Nicholas Krause CC: , , , , , Subject: Re: [PATCH] xilinx:Remove unused variable num_frag in the function axienet_start_xmit Message-ID: <20150617185848.GI2906@xsjsorenbubuntu> References: <1434556362-3748-1-git-send-email-xerofoify@gmail.com> <20150617160730.GE2906@xsjsorenbubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21618.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD051;1:3hf8JY5HL0VLyCCNXs4j3pp7Nz7fDXllD8BlPMX2W4a5BNG1wALqH+BvN89TbFL5kAA5mWEyqIGa4LGn5fuy4pyJUtYrr8cigtOJViFPLxCUt+KaHHYb/We8J8TCSpZzffH/DXACm87FSDZThzY2eTAooL1haIpFet2+BkwiKkR7HJ3enACvY4aM2kzIwk5a6km949TPfISxfN1OFioxx1s4LaavtrgQcw0CGxToIPIZ6OmNMrnoU0nXvb3Q9ffZWkVFmzolKb/jWsWNpaURs6IWEDYtgMaRuYkaIbuePIuBim1L/lM6aUY4LYEeFYmjtLEJeUKglS4NCehg7xi1fg== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(377424004)(189002)(377454003)(24454002)(51704005)(50986999)(76176999)(106466001)(54356999)(63266004)(86362001)(87936001)(85182001)(1411001)(2950100001)(76506005)(85202003)(23676002)(19580395003)(77096005)(83506001)(19580405001)(4001350100001)(81156007)(36386004)(5001960100002)(50466002)(110136002)(5001920100001)(33656002)(189998001)(6806004)(46102003)(33716001)(77156002)(47776003)(92566002)(57986006)(62966003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB026;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:ovrnspm;A:1;MX:1;PTR:unknown-60-83.xilinx.com;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB026;2:bkzU9qWxKHC28Y+nPNoA2VfVFw96xefnKSSRj3yQ+ezCHSU3+7Wi0pQyIACNNTsN;2:rmdsmZ/YvWTNYVHjQ2Yy/2sKeLDa56rnQHkYcePvmuRhWkFj6UELeFvn5H2xYhx80DfC31kLzR36wCn14pQ5lWDeXJQ+/mE4wrQGRoKptsUzvpJsgvwL7PNBh/Z1TagxgGpTYIfuel3ug3sywzXbD7stf2pfncGMSpPfhpPoCFEjYfK44Fm5Yj0N1c3LrXUf2I6a5+7jzqb9mmFmicXf6I+lKa+QO83zPIjKkTBTybo=;6:fSXVsCqG32k4ulnwPctg7tMFwhmRcezGEplGk8VZ70xuSDbTA1B5GlBQMTq+BXuCMxBH/KpLMya07l5GBKAT1yhQ9q6vIQLdFzRxEYip9jUjzLbC2W7sNqcEqrpXHjIZuISmbJg53BA6EPVUVvzcCe2IeXyjh8m8YLYF9SXuFOiFJTeB6vOY7YXtaDG2Q3dIIV5d0vRD+JvNmTqmcAugSkeuOym9W+Y16npgQLv/cThpOofd90joPTYvKwCg4Pfxh00i9tVGZkRBrVJA4iyqPt0YxrhQaFBb5ae3ETbL6UTgbt1OQ9k1g02b85KHaH8lunrtp762SUglqobtKr5DIMPpASEY6K1YDMg8X+Fq5p/HKAgEL1vUYeZjdEfsOWKHiviTKADN5Hn0SQiHRnnsX5xBdl2rMNlQe6SZDYcRkkjyc70hbXnq2gkd7zyQwf/ljLOWUUQED18+9Zl94gis0ckzbYkrJRaoj+47cqgATo7JgTHhijsBmfcOdkGIKA+G X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB026; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BN1AFFO11HUB026;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB026; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB026;3:2TPsjIHDGACqY9YudalwTFMjLUnQIMDt0UCYaN2Fdmr1lWlBFecoooh9W8FM6k5L+HJkcixRUwiaX32+GrizRCt293TwUhy/zFfmmkpTMBQEktVpdDgYuGK2Pi6ZwCzq5vc2QENftBaeZMQ+MN5Mnj8c1p+68iKM12oDcgI036CdUqbQjbC+WBVlBrOfHSHQU5GS075x9NfX7m1vSGxVwieOnVBqfsL2nC90LXRRQFoYidNQN6p9OQZEdwVIPEs5U6ClMwy3p/eXrQBK+GfFP+lpn/2i40xHpa4XSAMNaW5YCthdYznPYaYW3MHOqTFQ X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFBRkZPMTFIVUIwMjY7OTpMeW9GK3FhRUlxNUNmRzliTTUzWHIxK29F?= =?utf-8?B?dG1EdWoydW40Qy9MR3paU1dRcmcydXcrMDE5RlpOL1lSUE1QdldoNGJjdjc5?= =?utf-8?B?NVVZTTJweFd5SjVtZ01tSXpuZlB3MHA4Q252VC9vMzNUUUFGV2cxSUdSY0pU?= =?utf-8?B?VmhQdmlXUzBWMHRHRTNvSDB1YTNEUkd1RHl2SzVDY0F2bXdyaGdabGxNcTVH?= =?utf-8?B?NEVVdWxZeEplUXZoZ2xseStXbG5kYzkwMUh4bG5RV2ZhV0JOQkpMYTUzTjA4?= =?utf-8?B?SEpuZGpDa1NtaVdRcVhKaW9uQnVxSWhnWVFZVlFIUytXcnhyRXBCN1VieXNF?= =?utf-8?B?VUJBR1NuWWhqWkVOSmNEeVh3Y1U1R2gxRjE3dG1rVDNUQ1J1MEprUHNlUkhD?= =?utf-8?B?SkgxOUlMUkwwNDFGTHdlOG1PRGp1UXI3d3ZDbW9ZQmVVSHNrUXptcTdvZ09E?= =?utf-8?B?b25VWjJRUDZLMThoMG1FZ1phd0REUkFORXFBS1Jmemt2RHYrcVRyemZGYVJ5?= =?utf-8?B?L1pkQTNIYzM1bFBSang3Z1FkUDkxSVZBY0taUm5YNDBTOUhLaExaSFdRQjg5?= =?utf-8?B?SnY5Y3VlTENxazhudVBNaDUwVWRVNWcvUnFYUEJrb0EwT1g3ZEk5SzA3U052?= =?utf-8?B?Y09iT1Q5NXRhSUJnNWhtQ2h6R25tdWR2bnZNb0N5OW9FOVhZTTlNWVVoakU3?= =?utf-8?B?dGQ3bmZzZ1QyM2ZnY1R2T3U4WVhMd1MrNHJwMzB5aXFmNDZPWHZPRHFjYW9N?= =?utf-8?B?Y0M2UjdZNEJzNjFZR0I2TGJvcVByN1g4WElSUWFDK29rTDc5Z0VwSzNRRXFY?= =?utf-8?B?MkIzc3JwUlA0cFBmR3JYZVN2NHZBWkJkeUl0MzNFSk5nblFadUsveHZsekxS?= =?utf-8?B?RnkyUFJRcTFMcEh2WE1Zejd2LzJkRDBHWFd4K2h4NmR0aVdlQWUxNkJ6ZURN?= =?utf-8?B?citTZUVpVGdIUzdIaEJvN1p6R2hpZUVyS25weWRIL20vK0l3S3VGbVAraGww?= =?utf-8?B?M0RhRzJqOWFNbGhhVkxZa29IRTljdDBRalJFRmNBcWF1WktyekIyWHZtTDVT?= =?utf-8?B?RVpZek1VOG1CUW4yQnVZT1lkc3M1UXE5TTZhUFVPelVUWHhEN0VUemo5cFA0?= =?utf-8?B?OG5jaUg3ekFKQ2RmOElxWEV1QkE0R20zYndaaTNDTGpMSFV3NDY2OGh5aUh0?= =?utf-8?B?RjRQMFZpeEpBaDhwWmpEdVRJSVJobkt2N3VTODNCcDE3OU5zaEZvZzduYy94?= =?utf-8?B?R2tuWFlPbWFNMUtyUEFOQ0ZiZDNtTDNSeGh5U2M1VXRiaU5DaUtvWmYra29x?= =?utf-8?B?SUJ2ZWxRS1BhWTNOMTdVZWp6LzJ6eVlESVlXZ0tFam80VHlrck0xTGJGd1lS?= =?utf-8?B?d2JwMGx0V01PcDNHalVCM3JEek0vRjNPdUVnemNnNlRCekRPT2ZyT3VVWndI?= =?utf-8?B?b0xScngzbVJTSG9ud2JnRTFleS9LMHRDUzdkdlQzYkdsQ2h5aXVyRlZTQlJw?= =?utf-8?Q?JAMOFTr9WAAIfpjl1NtXo1jwZCy+28P/bnl+kUnHUC3zZYt?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB026;3:Vl/n2jXVH1HAZ2k+2z6RkRYkjV77ufw6cUFdRWrmWWcOgp5Kpnn/Jv7d6ViIaoCrVaJ3akxMnGwBssF3yfKZ6VOOMXWWAFkzywjX1qltMEBQGWw4luK4Vvlt47o4GrHPlM9SErgFOwBcIUEavssKYA==;10:26m6CRPZ61LuN5c1TJy6GWQ+bYlUAPpgiQuGBBYHzi/IiF5ai8GoC4D9pKcUYdohLgtbds8aQX4vb0Grml+6j+a808qLs1OTT2ScBNNz2mU= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 18:58:56.4970 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB026 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-06-17 at 12:21PM -0400, Nicholas Krause wrote: > > > On June 17, 2015 12:07:30 PM EDT, "Sören Brinkmann" wrote: > >On Wed, 2015-06-17 at 11:52AM -0400, Nicholas Krause wrote: > >> This removes the unused variable num_frag and the setting of it > >> to the number of fragments from the passed sk_buff pointer by > >> this function's caller due to this variable never being used > >> in this particular function and is not declared as global so > >> setting it for global use in this file is pointless. > >> > >> Signed-off-by: Nicholas Krause > >> --- > >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > >b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > >> index 28b7e7d..624dce4 100644 > >> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > >> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > >> @@ -651,7 +651,6 @@ static inline int > >axienet_check_tx_bd_space(struct axienet_local *lp, > >> static int axienet_start_xmit(struct sk_buff *skb, struct net_device > >*ndev) > >> { > >> u32 ii; > >> - u32 num_frag; > >> u32 csum_start_off; > >> u32 csum_index_off; > >> skb_frag_t *frag; > >> @@ -659,7 +658,6 @@ static int axienet_start_xmit(struct sk_buff > >*skb, struct net_device *ndev) > >> struct axienet_local *lp = netdev_priv(ndev); > >> struct axidma_bd *cur_p; > >> > >> - num_frag = skb_shinfo(skb)->nr_frags; > >> cur_p = &lp->tx_bd_v[lp->tx_bd_tail]; > >> > >> if (axienet_check_tx_bd_space(lp, num_frag)) { > > > >It's used right here, isn't it (and further down in this function too)? > >Does your tree compile with this change? > > > > Sören > My tree does compile with this change. You have to fix your testing process: CHK include/config/kernel.release UPD include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h UPD include/generated/utsrelease.h CHK include/generated/bounds.h CHK include/generated/timeconst.h CHK include/generated/asm-offsets.h CALL scripts/checksyscalls.sh :1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp] CC drivers/net/ethernet/xilinx/xilinx_axienet_main.o drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_start_xmit': drivers/net/ethernet/xilinx/xilinx_axienet_main.c:667:36: error: 'num_frag' undeclared (first use in this function) if (axienet_check_tx_bd_space(lp, num_frag)) { ^ drivers/net/ethernet/xilinx/xilinx_axienet_main.c:667:36: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:258: recipe for target 'drivers/net/ethernet/xilinx/xilinx_axienet_main.o' failed make[1]: *** [drivers/net/ethernet/xilinx/xilinx_axienet_main.o] Error 1 Makefile:1545: recipe for target 'drivers/net/ethernet/xilinx/xilinx_axienet_main.o' failed make: *** [drivers/net/ethernet/xilinx/xilinx_axienet_main.o] Error 2 NACK for the patch. Sören