From: Ingo Molnar <mingo@kernel.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.
Date: Thu, 18 Jun 2015 18:26:27 +0200 [thread overview]
Message-ID: <20150618162627.GB6989@gmail.com> (raw)
In-Reply-To: <5582ED6D.4010707@suse.cz>
* Martin Liška <mliska@suse.cz> wrote:
> To compare two records on an instruction base, with --show-total-period
> option provided, display total number of samples that belong to a line
> in assembly language.
>
> Signed-off-by: Martin Liska <mliska@suse.cz>
> ---
> tools/perf/builtin-annotate.c | 2 ++
> tools/perf/ui/browsers/annotate.c | 44 +++++++++++++++++++++++++--------------
> tools/perf/util/annotate.c | 28 +++++++++++++++++++------
> tools/perf/util/annotate.h | 3 ++-
> 4 files changed, 54 insertions(+), 23 deletions(-)
>
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 4e08c2d..2c1bec3 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -329,6 +329,8 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
> "objdump binary to use for disassembly and annotations"),
> OPT_BOOLEAN(0, "group", &symbol_conf.event_group,
> "Show event group information together"),
> + OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period,
> + "Show a column with the sum of periods"),
> OPT_END()
What is the toggle for this in the 'perf report' TUI? (which displays annotated
output too)
Thanks,
Ingo
next prev parent reply other threads:[~2015-06-18 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:10 Martin Liška
2015-06-18 16:26 ` Ingo Molnar [this message]
2015-06-18 18:06 ` Martin Liška
2015-06-18 19:15 ` Arnaldo Carvalho de Melo
2015-06-19 9:35 ` Martin Liška
2015-06-19 19:10 ` Arnaldo Carvalho de Melo
2015-06-20 11:53 ` Martin Liška
2015-06-22 14:38 ` Arnaldo Carvalho de Melo
2015-06-19 23:15 ` [tip:perf/core] perf annotate: Display total number of samples with --show-total-period tip-bot for Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618162627.GB6989@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome