From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023AbbFSSIZ (ORCPT ); Fri, 19 Jun 2015 14:08:25 -0400 Received: from mga03.intel.com ([134.134.136.65]:23763 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754668AbbFSSIR (ORCPT ); Fri, 19 Jun 2015 14:08:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,644,1427785200"; d="scan'208";a="746660253" Subject: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED To: dave@sr71.net Cc: dave.hansen@linux.intel.com, john@johnmccutchan.com, rlove@rlove.org, eparis@parisplace.org, viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org From: Dave Hansen Date: Fri, 19 Jun 2015 11:07:42 -0700 Message-Id: <20150619180742.62D31523@viggo.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Hansen I have a little microbenchmark that sits and does write() in a loop. The number one kernel function in the profiles is __srcu_read_lock() from fsnotify(). I decided to turn off INOTIFY in order to see what the potential from optimizing this path would be. I ended up with a system at the rescue console as systemd complained that dependencies were not met mounting some non-root filesystems: systemd: inotify_init1() failed: Function not implemented systemd: Dependency failed for Mark the need to relabel after reboot. systemd: Triggering OnFailure= dependencies of local-fs.target. systemd: inotify_init1() failed: Function not implemented systemd: Dependency failed for /gcc. It looks like CONFIG_INOTIFY is now a critical part of any system that wants to both use systemd and boot. Let's make it depend on CONFIG_EMBEDDED. Signed-off-by: Dave Hansen Cc: John McCutchan Cc: Robert Love Cc: Eric Paris Cc: Alexander Viro Cc: Linus Torvalds Cc: linux-kernel@vger.kernel.org --- b/fs/notify/inotify/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off fs/notify/inotify/Kconfig --- a/fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off 2015-06-19 10:54:06.528721072 -0700 +++ b/fs/notify/inotify/Kconfig 2015-06-19 10:55:16.426892530 -0700 @@ -1,5 +1,5 @@ config INOTIFY_USER - bool "Inotify support for userspace" + bool "Inotify support for userspace" if EMBEDDED select ANON_INODES select FSNOTIFY default y _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/