mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference
Date: Mon, 22 Jun 2015 09:49:58 +0200	[thread overview]
Message-ID: <20150622074958.GB2899@c203.arch.suse.de> (raw)
In-Reply-To: <556DB350.4000803@roeck-us.net>

On Tue, Jun 02, 2015 at 06:44:48AM -0700, Guenter Roeck wrote:
> On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> >In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> >a21_wdt_drv->wdt but never assign it.
> >
> >Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> >call, so it doesn't look like an error.
> >
> >Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> 
> Good catch.
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Guenter
> 

Hi Wim,

Any objections to this one? Do you intent to take it for 4.2?

Thanks,
	Johannes

-- 
Johannes Thumshirn                                       Storage
jthumshirn@suse.de                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2015-06-22  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 10:25 Johannes Thumshirn
2015-06-02 13:44 ` Guenter Roeck
2015-06-22  7:49   ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150622074958.GB2899@c203.arch.suse.de \
    --to=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®