From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933172AbbFVOIA (ORCPT ); Mon, 22 Jun 2015 10:08:00 -0400 Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:33477 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753886AbbFVOHx (ORCPT ); Mon, 22 Jun 2015 10:07:53 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:4362:4385:5007:6261:7875:7903:9010:10004:10400:10450:10455:10848:10967:11026:11232:11473:11658:11914:12043:12050:12438:12517:12519:12555:12663:12740:13069:13311:13357:14096:14097:19904:19999:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: songs53_9e47034a883c X-Filterd-Recvd-Size: 2361 Date: Mon, 22 Jun 2015 10:07:46 -0400 From: Steven Rostedt To: Umesh Tiwari Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, gupta.namit@samsung.com, pankaj.m@samsung.com Subject: Re: [PATCH] ftrace: correct the counter increment for trace_buffer data Message-ID: <20150622100746.2612d943@gandalf.local.home> In-Reply-To: <1434972306-20043-1-git-send-email-umesh.t@samsung.com> References: <1434972306-20043-1-git-send-email-umesh.t@samsung.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2015 16:55:06 +0530 Umesh Tiwari wrote: > In ftrace_dump, for disabling buffer, iter.tr->trace_buffer.data is used. > But for enabling, iter.trace_buffer->data is used. > Even though, both point to same buffer, for readability, same convention > should be used. Thanks for the two patches. I'm placing these in my todo list, and hopefully wont forget them. The merge window just opened, which means I wont get to them until after it closes (probably in two weeks). And with vacations coming up, it may be later than that. Feel free to ping me again in three weeks. Even if you don't, I will eventually get to them, but depending on how much other work piles up, it could take months. Sorry about the bad timing here. -- Steve > > Signed-off-by: Umesh Tiwari > --- > kernel/trace/trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 62c6506..e6dc9c3 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -6698,7 +6698,7 @@ void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) > trace_init_global_iter(&iter); > > for_each_tracing_cpu(cpu) { > - atomic_inc(&per_cpu_ptr(iter.tr->trace_buffer.data, cpu)->disabled); > + atomic_inc(&per_cpu_ptr(iter.trace_buffer->data, cpu)->disabled); > } > > old_userobj = trace_flags & TRACE_ITER_SYM_USEROBJ; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/