Re: [PATCH 1/1] regmap: debugfs: Allow writes to cache state settings

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Mon, Jun 22, 2015 at 04:30:34PM +0100, Richard Fitzgerald wrote:

This looks basically good but:

> +static ssize_t regmap_bool_read_file(struct file *file,
> +				     char __user *user_buf,
> +				     size_t count, loff_t *ppos,
> +				     bool value)
> +{
> +	char buf[2];
> +
> +	buf[0] = value ? 'Y' : 'N';
> +	buf[1] = '\n';
> +	return simple_read_from_buffer(user_buf, count, ppos, buf, sizeof(buf));
> +}

> +static ssize_t regmap_bool_write_file(struct file *file,
> +				      const char __user *user_buf,
> +				      size_t count, loff_t *ppos,
> +				      bool *value)
> +{

Can we not export read/write_file_bool() instead?  For the read this
seems to be an almost cut'n'paste with slight differences that look
like taste changes.  For the write path we can just stash the current
value in the calling functions instead of cut'n'pasting the code.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]