From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbbFVQAH (ORCPT ); Mon, 22 Jun 2015 12:00:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53260 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbbFVQAD (ORCPT ); Mon, 22 Jun 2015 12:00:03 -0400 Date: Mon, 22 Jun 2015 09:00:02 -0700 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Linux Kernel Mailing List , Dave Kleikamp , Jens Axboe , Zach Brown , Maxim Patlasov , Andrew Morton , Alexander Viro , Tejun Heo , Dave Chinner Subject: Re: [PATCH v5 5/5] block: loop: support DIO & AIO Message-ID: <20150622160002.GB10307@infradead.org> References: <1433857766-6153-1-git-send-email-ming.lei@canonical.com> <1433857766-6153-6-git-send-email-ming.lei@canonical.com> <20150610074611.GD6964@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2015 at 08:09:55PM +0800, Ming Lei wrote: > For the general async interface, it is a bit complicated than sync interfaces: > > - iocb need to be one parameter, because it often depends on callers, such > as loop can preallocate it > - direct I/O need to be another parameter(in loop we can use the same helper > to handle sync request) > - bvec and the segment number are another two parameters > - not mention the common parameters(file, offset, pos, complete...) We only really need iocb + iov_iter, they carry everything we need. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/