From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbbFVRTs (ORCPT ); Mon, 22 Jun 2015 13:19:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55667 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbbFVRTl (ORCPT ); Mon, 22 Jun 2015 13:19:41 -0400 Date: Mon, 22 Jun 2015 19:19:39 +0200 From: "Luis R. Rodriguez" To: Borislav Petkov Cc: Fengguang Wu , Ingo Molnar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, LKP Subject: Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init() Message-ID: <20150622171939.GR11147@wotan.suse.de> References: <20150620071756.GA10923@wfg-t540p.sh.intel.com> <20150620110844.GA30725@pd.tnic> <20150621202348.GP11147@wotan.suse.de> <20150621204120.GA11833@pd.tnic> <20150622010138.GQ11147@wotan.suse.de> <20150622070641.GA19872@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622070641.GA19872@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2015 at 09:06:41AM +0200, Borislav Petkov wrote: > On Mon, Jun 22, 2015 at 03:01:38AM +0200, Luis R. Rodriguez wrote: > > We can certainly replace the WARN() with pr_warn(), I don't see > > how its confusing though as its a run time real issue. Either > > way whatever you recommend is fine by me. > > Yeah, it confused the 0day robot at least. :-) > > But maybe because it cannot really read. But I've experienced cases > where people don't read too, see *a* splat and raise the alarm. So yeah, > I think a simple pr_warn would be much better. OK I'll submit a follow up fix and say the robot reported it :) Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/