From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbbFVSmK (ORCPT ); Mon, 22 Jun 2015 14:42:10 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:35366 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbbFVSmI (ORCPT ); Mon, 22 Jun 2015 14:42:08 -0400 Date: Mon, 22 Jun 2015 14:42:04 -0400 From: Tejun Heo To: Vivek Goyal Cc: Jens Axboe , Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/block_dev.c: Remove WARN_ON() when inode writeback fails Message-ID: <20150622184204.GD3710@mtj.duckdns.org> References: <20150622184118.GA11277@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622184118.GA11277@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2015 at 02:41:18PM -0400, Vivek Goyal wrote: > If a block device is hot removed and later last reference to devices > is put, we try to writeback the dirty inode. But device is gone and > that writeback fails. > > Currently we do a WARN_ON() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning. > > Reported-by: Andi Kleen > Signed-off-by: Vivek Goyal Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/