mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Fabio Coatti <fabio.coatti@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	Daniel Stone <daniel@fooishbar.org>,
	David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Linux 4.1 WARNING in drm_ioctl.c
Date: Tue, 23 Jun 2015 15:29:41 +0200	[thread overview]
Message-ID: <20150623132941.GC25769@phenom.ffwll.local> (raw)
In-Reply-To: <3759620.yiBZ6BaR05@calvin>

On Tue, Jun 23, 2015 at 12:46:09PM +0200, Fabio Coatti wrote:
> In data martedì 23 giugno 2015 11:48:47, Daniel Vetter ha scritto:
> > On Tue, Jun 23, 2015 at 08:27:13AM +0100, Daniel Stone wrote:
> > > Hi,
> > > 
> > > On 23 June 2015 at 07:39, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > Which drm driver are you using? I didn't spot anything in your module
> > > > list
> > > > but might have missed it. Booting with drm.debug=0xe and grabbing dmesg
> > > > will tell us for sure.
> > > 
> > > That'd be vgem.
> > 
> > If so then the below diff should help.
> > -Daniel
> > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c
> > b/drivers/gpu/drm/vgem/vgem_drv.c index 7a207ca547be..b491fb32cddb 100644
> > --- a/drivers/gpu/drm/vgem/vgem_drv.c
> > +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> > @@ -328,6 +328,8 @@ static int __init vgem_init(void)
> >  		goto out;
> >  	}
> > 
> > +	drm_dev_set_unique(drm, "vgem");
> > +
> >  	ret  = drm_dev_register(vgem_device, 0);
> > 
> >  	if (ret)
> 
> 
> Not really sure about "drm" in drm_dev_set_unique():
> 
>   CHK     include/generated/compile.h
>   GZIP    kernel/config_data.gz
>   CHK     kernel/config_data.h
>   CC      drivers/gpu/drm/vgem/vgem_drv.o
> drivers/gpu/drm/vgem/vgem_drv.c: In function ‘vgem_init’:
> drivers/gpu/drm/vgem/vgem_drv.c:331:21: error: ‘drm’ undeclared (first use in 
> this function)

s/drm/vgem_device/ ... copypaste fail without running gcc.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2015-06-23 13:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 14:04 Fabio Coatti
2015-06-23  6:39 ` Daniel Vetter
2015-06-23  7:12   ` Fabio Coatti
2015-06-23  7:27   ` Daniel Stone
2015-06-23  9:48     ` Daniel Vetter
2015-06-23 10:46       ` Fabio Coatti
2015-06-23 13:29         ` Daniel Vetter [this message]
2015-06-23 14:03           ` Fabio Coatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623132941.GC25769@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=daniel@fooishbar.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.coatti@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome